Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force select field height to prevent theme conflicts #2340

Closed
mathetos opened this issue Nov 14, 2017 · 0 comments

Comments

@mathetos
Copy link
Member

commented Nov 14, 2017

Issue Overview

Some themes force a height on select or input fields. This can cause problems with Floating Labels.

Expected Behavior

The floating labels inside the fields should always be visible.

Current Behavior

Theme's add something like height: 35px to a select and/or input field and it looks like this:
image

Possible Solution

[id*=give-form] .fl-form.fl-style-give select.fl-select {
    height: auto;
}

Probably want to apply it to floating label INPUTS as well so that they are all the same height.

Steps to Reproduce (for bugs)

  1. Add this into your child-theme styles.css file:
    * select, * input {height: 15px; padding: 15px;}
  2. Enable floating labels, confirm that the label is no longer visible
  3. Add the CSS snippet in the "Possible Solution" above into the Give CSS, confirm it's fixed

Related Issues and/or PRs

May be related:
#1511

@DevinWalker DevinWalker added this to the 2.1 milestone Nov 15, 2017

@ravinderk ravinderk added the UI / UX label Dec 5, 2017

@DevinWalker DevinWalker modified the milestones: 2.1, 2.0.1 Dec 5, 2017

@ravinderk ravinderk modified the milestones: 2.0.1, 2.0.2 Jan 22, 2018

@ravinderk ravinderk modified the milestones: 2.0.2, 2.0.3 Jan 30, 2018

@ravinderk ravinderk added the has pr label Feb 13, 2018

DevinWalker pushed a commit that referenced this issue Feb 13, 2018
Devin Walker
Merge pull request #2804 from Sidsector9/issue-2340
Force select field height to prevent theme conflicts #2340
DevinWalker added a commit that referenced this issue Feb 15, 2018
Merge branch 'master' into licensing-revamp
* master: (185 commits)
  doc(release): ran pre-release gulp
  doc(release-changelog): remove line break and dupe entries
  doc(release): added change log, ran gulp, new POT file for release 2.0.3
  fix(chosen-style): remove bubble button look from chosen dropdowns in 2.0.3
  fix(float-labels-style): improve theme compatiblity by only targetting fl-label inputs #2340
  fix(i18n-string): use date_i18n() rather than date() for localization
  doc(release): prepare changelog and bump version for 2.0.3 release
  fix(doc-link): open doc link in new window
  fix(setting): use div to wrap setting field instead p
  fix(emails): update email message setting field desc
  fix(form): add data attribute to manage donate button label
  fix(email): replace only first occurrence of meta type
  fix(email): remove error_log
  style(email): update function desc
  feat(email): add email tag meta_*
  fix(shortcodes): display forms with publish status only
  style: improve code formatting
  fix(donation-form): improve if condition
  Fix #2807
  fix(assets/js): Update amount to precision
  ...
DevinWalker added a commit that referenced this issue Feb 15, 2018
Merge branch 'release/2.0.4' into release/2.1
* release/2.0.4: (79 commits)
  doc(version-update): bump version to 2.0.4 on branch
  fix(gulp): ignore some directories when run textdomain comman
  Wrong text domain
  doc(pot): ran gulp POT for release 2.0.3
  fix(db-update): perform update pause even if batch empty
  doc(readme): add "give" and "givewp" as tags to readme
  doc(release): ran pre-release gulp
  doc(release-changelog): remove line break and dupe entries
  doc(release): added change log, ran gulp, new POT file for release 2.0.3
  fix(chosen-style): remove bubble button look from chosen dropdowns in 2.0.3
  fix(float-labels-style): improve theme compatiblity by only targetting fl-label inputs #2340
  fix(i18n-string): use date_i18n() rather than date() for localization
  doc(release): prepare changelog and bump version for 2.0.3 release
  fix(doc-link): open doc link in new window
  fix(setting): use div to wrap setting field instead p
  fix(emails): update email message setting field desc
  fix(form): add data attribute to manage donate button label
  fix(email): replace only first occurrence of meta type
  fix(email): remove error_log
  style(email): update function desc
  ...

# Conflicts:
#	assets/css/give-admin-rtl.css
#	assets/css/give-admin-rtl.min.css
#	assets/css/give-admin.css
#	assets/css/give-admin.min.css
#	assets/js/frontend/give-donations.js
#	assets/js/frontend/give-donations.min.js
#	assets/js/frontend/give.all.min.js
#	assets/js/plugins/chosen.jquery.js
#	assets/js/plugins/chosen.jquery.min.js
#	assets/js/plugins/float-labels.js
#	assets/js/plugins/float-labels.min.js
#	assets/sourcemaps/give-admin.css.map
#	assets/sourcemaps/give.css.map
#	give.php
#	gulpfile.js
#	languages/give.pot
#	readme.txt
#	templates/give-rtl.min.css
#	templates/give.min.css
DevinWalker added a commit that referenced this issue Feb 15, 2018
Merge branch 'release/2.1' into feature/gutenberg-donation-form-block
* release/2.1: (103 commits)
  doc(version-update): bump version to 2.0.4 on branch
  fix(gulp): ignore some directories when run textdomain comman
  Wrong text domain
  doc(pot): ran gulp POT for release 2.0.3
  fix(db-update): perform update pause even if batch empty
  doc(readme): add "give" and "givewp" as tags to readme
  doc(release): ran pre-release gulp
  doc(release-changelog): remove line break and dupe entries
  doc(release): added change log, ran gulp, new POT file for release 2.0.3
  fix(chosen-style): remove bubble button look from chosen dropdowns in 2.0.3
  fix(float-labels-style): improve theme compatiblity by only targetting fl-label inputs #2340
  fix(i18n-string): use date_i18n() rather than date() for localization
  doc(release): prepare changelog and bump version for 2.0.3 release
  fix(doc-link): open doc link in new window
  fix(setting): use div to wrap setting field instead p
  fix(emails): update email message setting field desc
  fix(form): add data attribute to manage donate button label
  fix(email): replace only first occurrence of meta type
  fix(email): remove error_log
  style(email): update function desc
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.