-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(admin-tool): PHP notices on system info page #2998
Comments
I'm seeing this error on all of my local sites and I confirmed that the system info in Help Scout tickets shows the error as well:
It seems like that service may require a paid subscription now with an API key. @DevinWalker should we attempt to find an alternative or just remove the TLS lines? |
@raftaar1191 good catch. @kevinwhoffman I would say just remove it. It's not very useful info as far as I know since support will likely get that info anyways outside the system info report. @mathetos please correct me if I'm wrong. I'm not sure of any alternative API for this... |
I do think the TLS testing is important particularly because payment gateways are starting to enforce TLS 1.2 across the board. I did a quick search, maybe this is a good replacement: |
@DevinWalker @matheos This issue has been fixed. Means PHP notice will generate conditionally. Reopen this issue if you still want to remove TLS from system info page. |
@ravinderk this API is not working anymore so we should replace it or remove it If we are planning to replace it with some another API than @mathetos has shared one API link in the above mention issues |
@DevinWalker PHP notice has been fixed. Let us know what is your final decision about changing API or remove information from system information page. |
@raftaar1191 @ravinderk preserve the SSL functionality by replacing it with the one linked to by Matt. |
Before this closes I'd also like to test this on multiple hosting environments just to ensure we're getting good info with the new API. Ping me when it's ready and I'll queue it up in all the host accounts I have access to. |
Reopening because the new API needs to be implemented. @mathetos you can easily test how it reacts to new environments by using the GUI found on the website tool. Our results will pull the very similar SSL stats. |
Slack Chat SummaryParticipants: @emgk, @ravinderk |
User Story
As an
Admin
, I don't want to get any PHP noticesGetting PHP notices when viewing the Tools page
Current Behavior
I currently I am getting a PHP notices when viewing Tools > System Info Page
Expected Behavior
I expect that we should not get any error when viewing the System Info Page inside Tools section
Steps to Reproduce
Visuals
Debug Log
Tasks
Environment
WordPress System Info
### WordPress Environment ###Home URL: http://give207.com
Site URL: http://give207.com
WP Version: 4.9.5
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: ✔
WP Cron: ✔
Language: en_US
Permalink Structure: /%year%/%monthnum%/%day%/%postname%/
Show on Front: posts
Table Prefix Length: wp_
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Accessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, refunded, failed, revoked, cancelled, abandoned, processing, preapproval
Server Environment
Hosting Provider: DBH: localhost, SRV: give207.com
TLS Connection: Connection uses The website calling howsmyssl.com's API has been making many calls and does not have a subscription. See https://subscriptions.howsmyssl.com/signup for how to get one.
TLS Connection: object(stdClass)#1252 (2) {
["error"]=>
string(36) "See tls_version for the sign up link"
["tls_version"]=>
string(167) "The website calling howsmyssl.com's API has been making many calls and does not have a subscription. See https://subscriptions.howsmyssl.com/signup for how to get one."
}
Notice: Undefined property: stdClass::$rating in /app/public/wp-content/plugins/Give/includes/admin/tools/views/html-admin-page-system-info.php on line 203
Server Info: nginx/1.10.1
PHP Version: 7.0.3
PHP Post Max Size: 1,000 MB
PHP Time Limit: 900
PHP Max Input Vars: 3000
PHP Max Upload Size: 1,000 MB
cURL Version: ❌ 7.38.0, OpenSSL/1.0.1t - We recommend a minimum cURL version of 7.40.
SUHOSIN Installed: –
MySQL Version: ❌ 5.5.55 - We recommend a minimum MySQL version of 5.6. See: WordPress Requirements
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔
Give Configuration
Give Version: 2.1.0
Give Cache: Enabled
Database Updates: All DB Updates Completed.
Give Cache: Enabled
Give Cache: ✔New Donation✔Donation Receipt✔New Offline Donation✔Offline Donation Instructions✔New User Registration✔User Registration Information✔Email access
Upgraded From: –
Test Mode: Enabled
Currency Code: USD
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: http://give207.com/donation-confirmation/
Failure Page: http://give207.com/donation-failed/
Donation History Page: http://give207.com/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Test Donation, Offline Donation
Default Payment Gateway: Test Donation
PayPal IPN Verification: Enabled
PayPal IPN Notifications: N/A
Donor Email Access: Enabled
Session Configuration
Give Use Sessions: Enabled
Session: Disabled
Active Give Add-ons
Other Active Plugins
Inactive Plugins
Braintree For WooCommerce Free: by Payment Plugins, support@paymentplugins.com – 2.6.22
Braintree WooCommerce Addon: by Syed Nazrul Hassan – 1.0.0
BuddyPress: by The BuddyPress Community – 2.9.4
Caldera Forms: by Caldera Labs – 1.6.0
Charitable: by WP Charitable – 1.5.13
Constant Contact Plugin for WordPress: by Katz Web Services, Inc. – 4.1.1
Duplicate Post: by Enrico Battocchi – 3.2.1
Email Cop: by Ashfame – 0.1.1
Give - 2Checkout Gateway: by WordImpress – 1.0.2
Give - Authorize.net Gateway: by WordImpress – 1.3.3
Give - AWeber: by WordImpress – 1.0.2
Give - Braintree Gateway: by WordImpress – 1.1
Give - CCAvenue Gateway: by WordImpress – 1.0
Give - Constant Contact: by WordImpress – 1.2.1
Give - ConvertKit: by WordImpress – 1.0.1
Give - CSV Toolbox: by WordImpress – 1.0
Give - Currency Switcher: by WordImpress – 1.0.3
Give - Development Plugin: by Raftaar1191 – 1.0.0
Give - Display Donors: by WordImpress, LLC – 1.0
Give - Dwolla Gateway: by WordImpress – 1.1.2
Give - Email Reports: by WordImpress – 1.1.1
Give - Fee Recovery: by WordImpress – 1.3.8
Give - Form Countdown: by WordImpress – 1.0
Give - Form Field Manager: by WordImpress – 1.2.8
Give - Gift Aid: by WordImpress – 1.1.1
Give - Google Analytics Donation Tracking: by WordImpress – 1.1.3
Give - MailChimp: by WordImpress – 1.3.7
Give - Manual Donations: by WordImpress – 1.2.2
Give - Paymill Gateway: by WordImpress – 1.1
Give - PayPal Pro Gateway: by WordImpress – 1.1.4
Give - PDF Receipts: by WordImpress – 2.2.4
Give - Recurring Donations: by WordImpress – 1.5.7
Give - Stripe Gateway: by WordImpress – 1.5.2
Give - Tributes: by WordImpress – 1.4.1
Give - Zapier: by WordImpress – 1.1.2
Gravity Forms: by rocketgenius – 2.2.6
Gravity Forms Signature Add-On: by Rocketgenius – 3.4
Loco Translate: by Tim Whitlock – 2.1.2
My Calendar: by Joseph C Dolson – 2.5.17
Polylang: by Frédéric Demarle – 2.3.4
WooCommerce: by Automattic – 3.3.4
WooCommerce PayPal Powered by Braintree Gateway: by WooCommerce – 2.1.1
WP Hide & Security Enhancer: by Nsp Code – 1.4.8.2
WPS Hide Login: by WPServeur, NicolasKulka, tabrisrp – 1.2.6.1
YITH Donations for WooCommerce: by YITHEMES – 1.0.17
Theme
Name: Twenty Seventeen
Version: 1.4
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme
Operating System
Browser
The text was updated successfully, but these errors were encountered: