a11y Review List

[mathetos]

I'm making this into a list of a11y issues that were brought up in an accessibility review by Jordan Quintal. Each item will be linked to it's respective issue and marked off as they are completed. That way we know the entire first review is complete.

• <input id="give-amount"> creates multiple IDs on the page when multiple forms are present (Issue id="give-amount" output multiple times on the page #326 )
• <input class="give-text-input" name="give-amount"> doesn't have a label (Issue <input class="give-text-input" name="give-amount"> doesn't have a label #328)
• id="give-form-{ID}"is output twice on the page, once as a div, once as the form ID (Issue id="give-form-{ID}"is output twice on the page, once as a div, once as the form ID #329)
• id="give-amount" is output twice on the page (Issue id="give-amount" is output twice on the page, once as an input, once as a span #330)
• Multi-level select field has no label (Issue Multi-level select field has no label #331)
• Login form has a <p> with no text in it. It's the <p> for the Submit Button (Issue Login form has a <p> with no text in it. It's the <p> for the Submit Button #332)
• Make ALL ids unique to avoid identical IDs when multiple forms are on the same page. (Issue Make ALL the ids be unique to avoid multiple identical ids when multiple forms are on the page #379)

This is the whole list boiled down. I'll add links to each item as I create the Issues for them.

[DevinWalker]

Nice, I didn't know you create a master task like this with items attached 👍

[michaelbeil]

fancy shmancy. kudos on the a11y improvements!

[mathetos]

Thanks @michaelbeil ! Overall, we're pretty happy with the fact that it seems like only minor improvements needed.

[mathetos]

@DevinWalker All Issues now currently have PR's. Please review and merge. Then we can upload the new master to the demo site and @TheGeniusWM can do a revised #a11y review to see if we've resolved all the things. Thanks!

[mathetos]

Just added Issue #379 to the list which already has a PR but it's pretty significant so it will need careful inspection. Heads up on that @DevinWalker

[DevinWalker]

@mathetos can you iron out the conflicts in your PR and resubmit when you get the chance?

[ramiy]

#858 a11y in give shortcode

[ramiy]

@mathetos,

Please review core <a> tags title attributes changes. We should either remove the title attributes, or replace them with aria-label attributes.

https://core.trac.wordpress.org/changeset/25743
https://core.trac.wordpress.org/changeset/29583
https://core.trac.wordpress.org/changeset/32981
https://core.trac.wordpress.org/changeset/35998
https://core.trac.wordpress.org/changeset/35905
https://core.trac.wordpress.org/changeset/36222
https://core.trac.wordpress.org/changeset/36016
https://core.trac.wordpress.org/changeset/36333
https://core.trac.wordpress.org/changeset/36331
https://core.trac.wordpress.org/changeset/36298

[ramiy]

One more fix we need to implement is the "close button". Remove the title attribute and move the text into a span with class='screen-reader-text' like it's done in: https://core.trac.wordpress.org/changeset/37531

[ramiy]

@mathetos

Check out this commit - https://core.trac.wordpress.org/changeset/37680

When writing strings, help text shouldn't assume users can see.

We should avoid reference to "visual" positions in favor of positions in the document structure.

[mathetos]

Thanks to the initial #a11y review from @TheGeniusWM and then the very detailed Admin and front-end follow-up from @ramiy Give is now very thoroughly #a11y-compliant. The latest changes in version 1.7 will complete this effort. It'll be up to us to continue to maintain this status as the plugin continues to develop.

Thanks so much guys!