Add select box to choose logo size on email tab in settings #1159
Conversation
| $header_img = give_get_option( 'email_logo', '' ); | ||
| $header_img_id = give_get_option( 'email_logo_id', '' ); | ||
| $logo_size = give_get_option( 'email_logo_size', '' ); | ||
| $header_img = $header_img_id == '' ? give_get_option( 'email_logo' ) : wp_get_attachment_image_src( $header_img_id, $logo_size )[0]; |
There was a problem hiding this comment.
@philwp please validate wp_get_attachment_image_src before getting first element of array because this function can be return false.
for ref: https://developer.wordpress.org/reference/functions/wp_get_attachment_image_src/#return
| @@ -543,6 +543,19 @@ public function give_settings( $active_tab ) { | |||
| 'type' => 'file' | |||
| ), | |||
| array( | |||
| 'id' => 'email_logo_size', | |||
There was a problem hiding this comment.
@philwp nowadays emails are responsive, so I did not think to give the admin the option to select logo size has more benefits than giving admin an option for email logo, so admin has full freedom to select upload their own size.
There was a problem hiding this comment.
@ravinderk I ran into an issue where the image that one of my clients wanted to use was too large to look good in an email. The image was over 500px wide and I needed to manually enter the path to a smaller version of it.
There was a problem hiding this comment.
@philwp It seems the most specific problem then general. It is easy to crop and upload an image and then assign as email logo.
@DevinWalker What do you think?
|
@ravinderk I personally have had the issue of uploading an image that is too large and felt frustrated by that. Personally, I like this field. @mathetos @kevinwhoffman what do you think? |
|
@philwp can you switch this over to the |
|
I just tested and it is a nice addition especially for users who may already have a high-resolution logo uploaded and lack the graphics editing skills to create a specially sized logo just for emails. With that said, we should also have a max-width style applied to that image in the event that an oversized image is selected. |
|
@kevinwhoffman I agree on the max-width style for the image. I just set a huge image and tested and it looked pretty terrible. |
|
@DevinWalker I already added max-width into
|
|
Ah, I see @ravinderk do in |
|
@DevinWalker I developed model now but max width already exists. Let me know if you are good with this model , I will create pr then |
Description
When adding a logo image in the 'emails' settings tab you cannot select which size image you want to display. I added a select box which uses the native WP image sizes to control the image size displayed in the email.
How Has This Been Tested?
I used multiple images testing all sizes in the email preview view. I also tested using a URL from an image hosted on another site.
Types of changes
Checklist: