Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out qtip.js for hint.css #217

Closed
mathetos opened this issue Aug 30, 2016 · 4 comments · Fixed by impress-org/Maps-Builder-Core#52 or #266
Closed

Swap out qtip.js for hint.css #217

mathetos opened this issue Aug 30, 2016 · 4 comments · Fixed by impress-org/Maps-Builder-Core#52 or #266
Assignees

Comments

@mathetos
Copy link
Member

We're ditching qtip.js on Give (see here ), I'd like to ditch it here as well, it breaks too easily and ends up breaking functionality across the plugin.

Here's hint.css info

I think our implementation in GMB is relatively simple so I don't anticipate any problems, just different markup really.

@lchski Do you anticipate any backward compatibility issues at all with this?

@mathetos mathetos added this to the 2.1 milestone Aug 30, 2016
@lchski
Copy link

lchski commented Aug 30, 2016

I don’t see what backward compatibility issues could arise; as long as all the markup is updated correctly, we should be fine.

@lchski
Copy link

lchski commented Sep 8, 2016

I made progress towards this in maps-builder-core/217-hint-css; it’ll need to be removed once the new InfoWindows are working. The JS-version could position itself relative to the windows fine, but the hint.css version was having a few clipping issues. I didn’t investigate further, though, because they’re contingent on having a finalized InfoWindow.

@DevinWalker
Copy link
Member

This is too big of a change to hold up 2.1 - bumping

@nishitlangaliya
Copy link
Contributor

@DevinWalker ,

I have removed the qtip.js from maps builder core and implemented hint.css and done below two PR for the same.

  1. fix(google-maps-builder): hint.css file added #266
  2. fix(google-maps-builder): Removed qtip.js and implement hint.css Maps-Builder-Core#52

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants