New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap out qtip.js for hint.css #217
Swap out qtip.js for hint.css #217
Comments
I don’t see what backward compatibility issues could arise; as long as all the markup is updated correctly, we should be fine. |
I made progress towards this in maps-builder-core/217-hint-css; it’ll need to be removed once the new InfoWindows are working. The JS-version could position itself relative to the windows fine, but the hint.css version was having a few clipping issues. I didn’t investigate further, though, because they’re contingent on having a finalized InfoWindow. |
This is too big of a change to hold up 2.1 - bumping |
I have removed the qtip.js from maps builder core and implemented hint.css and done below two PR for the same.
Thanks |
We're ditching qtip.js on Give (see here ), I'd like to ditch it here as well, it breaks too easily and ends up breaking functionality across the plugin.
Here's hint.css info
I think our implementation in GMB is relatively simple so I don't anticipate any problems, just different markup really.
@lchski Do you anticipate any backward compatibility issues at all with this?
The text was updated successfully, but these errors were encountered: