New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clarify Facebook OAuth errors #269

Open
kevinwhoffman opened this Issue Oct 10, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@kevinwhoffman
Member

kevinwhoffman commented Oct 10, 2018

Bug Report

User Story

As a user, I want a clear description of why my request to get reviews was not successful so that I can take steps to fix it.

These OAuth errors are most likely caused by the Facebook data breach that invalidated access tokens. Based on the error, it's unclear whether Facebook invalidated all access tokens automatically, or whether that only happens after a password reset.

Current Behavior

When I click Get Reviews I see an error stating Invalid response structure when the error is actually caused by an invalid access token.

Here is the error being returned by the API:

Error validating access token: The session has been invalidated because the user changed their password or Facebook has changed the session for security reasons.

Expected Behavior

I expect to see an error that tells me why the request was unsuccessful with instructs to fix it.

Bug Type

  • This bug describes functionality that once worked as expected in version X.X.X.
  • This bug describes functionality that never worked as expected.
  • I am not sure whether this functionality ever worked as expected.

Steps to Reproduce

  1. Create a new Facebook collection.
  2. Click Get Reviews.
  3. Note the error, which may or may not appear depending on how recently your access tokens were generated.

Visuals

The current error displayed to users:
image

The actual error returned by the API:
image

Possible Solution

Update the error logic to return an error message that instructs the user to reconnect to Facebook in order to renew the page tokens. Provide a link in the error message that returns the user to the settings screen where Facebook is disconnected.

Acceptance Criteria

  • When the OAuth error occurs, an appropriate red error is displayed that communicates the invalid page token.
  • A link is present in the error that returns the user to the Facebook settings screen.

@kevinwhoffman kevinwhoffman self-assigned this Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment