Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Refactored impress.js into an object while maintaining backward-compatibility with v0.3 #112
I refactored the impress.js source into an object with a couple of goals:
I've managed to shave ~40 lines of code while (in my opinion at least) enhancing readability. The new impress function can either be constructed with
Keep up the fantastic work and let me know if you'd like to integrate my changes but would like me to make any more modifications first,
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Impressive refactoring indeed.
But it's way to much for me to use it as it is. And I don't agree with all decisions you made there. I don't see allowing to use
So, thanks for your input. For sure I will be looking at your code in more details to search for inspiration and improvements.