Making impress.js compatible with SVG #143

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@csicar

csicar commented Apr 25, 2012

Why?
Creating the "Presentation-Map" in a vector program is easier than in HTML the data-* tags can be added there, too.
What was the problem?
SVG-Elements have no Attribute classList, what produces errors. The code adds those Attributes to the SVG-Elements. (I want to add some other things, which makes it even better to use with SVG)

/Problems with the code-style? -> Tell me a better method of doing it/

This commit adds support to SVG as steps; the issues were caused by s…
…ome missing properties for class-editing. There's still a problem with the click-event an line 779
@bartaz

This comment has been minimized.

Show comment
Hide comment
@bartaz

bartaz May 5, 2012

Member

I used HTML5 classList to avoid having to implement it myself.
I understand that it may not be the best for browser support (and SVG).

I would have to think if I want to complicate impress.js source for it. Maybe it would be possible to add classList support for SVG elements separately from impress.js?

Member

bartaz commented May 5, 2012

I used HTML5 classList to avoid having to implement it myself.
I understand that it may not be the best for browser support (and SVG).

I would have to think if I want to complicate impress.js source for it. Maybe it would be possible to add classList support for SVG elements separately from impress.js?

@FagnerMartinsBrack

This comment has been minimized.

Show comment
Hide comment
@FagnerMartinsBrack

FagnerMartinsBrack Feb 3, 2016

Member

Hi @csicar, in an effort to clear up older issues/PRs we are pinging back to know if you are still tracking this request.

To give a little bit of context, recently a decision was made in the project to make the development more active and the first task is to clear up older issues like this one to see if the OP is still interested in keep it going.

Member

FagnerMartinsBrack commented Feb 3, 2016

Hi @csicar, in an effort to clear up older issues/PRs we are pinging back to know if you are still tracking this request.

To give a little bit of context, recently a decision was made in the project to make the development more active and the first task is to clear up older issues like this one to see if the OP is still interested in keep it going.

@csicar

This comment has been minimized.

Show comment
Hide comment
@csicar

csicar Feb 3, 2016

Well I am still interested in the project and think that the mesioned SVG
support would make use impress.js easier

Fagner Brack notifications@github.com schrieb am Mi., 3. Feb. 2016 13:39:

Hi @csicar https://github.com/csicar, in an effort to clear up older
issues/PRs we are pinging back to know if you are still tracking this
request.

To give a little bit of context, recently a decision was made in the
project
#435 (comment)
to make the development more active and the first task is to clear up older
issues like this one to see if the OP
http://netforbeginners.about.com/od/internetlanguage/f/What-Is-OP.htm
is still interested in keep it going.


Reply to this email directly or view it on GitHub
#143 (comment).

csicar commented Feb 3, 2016

Well I am still interested in the project and think that the mesioned SVG
support would make use impress.js easier

Fagner Brack notifications@github.com schrieb am Mi., 3. Feb. 2016 13:39:

Hi @csicar https://github.com/csicar, in an effort to clear up older
issues/PRs we are pinging back to know if you are still tracking this
request.

To give a little bit of context, recently a decision was made in the
project
#435 (comment)
to make the development more active and the first task is to clear up older
issues like this one to see if the OP
http://netforbeginners.about.com/od/internetlanguage/f/What-Is-OP.htm
is still interested in keep it going.


Reply to this email directly or view it on GitHub
#143 (comment).

@FagnerMartinsBrack

This comment has been minimized.

Show comment
Hide comment
@FagnerMartinsBrack

FagnerMartinsBrack Feb 3, 2016

Member

Thanks for the feedback!

Member

FagnerMartinsBrack commented Feb 3, 2016

Thanks for the feedback!

@henrikingo

This comment has been minimized.

Show comment
Hide comment
@henrikingo

henrikingo Aug 13, 2016

Contributor

Hi @csicar

Could you share a link or two to an example presentation you did in SVG? I'd like to work on integrating your suggestion, but without example content, it's hard to form an opinion on the code, where to put it, etc.

Contributor

henrikingo commented Aug 13, 2016

Hi @csicar

Could you share a link or two to an example presentation you did in SVG? I'd like to work on integrating your suggestion, but without example content, it's hard to form an opinion on the code, where to put it, etc.

@regebro

This comment has been minimized.

Show comment
Hide comment
@regebro

regebro Oct 25, 2016

Contributor

Btw, Hovercraft has svg support, and handles that by translating the SVG path to positions and rotations and uses that to generate the impress.js presentation. That might be interesting as an alternative/temporary solution.

Contributor

regebro commented Oct 25, 2016

Btw, Hovercraft has svg support, and handles that by translating the SVG path to positions and rotations and uses that to generate the impress.js presentation. That might be interesting as an alternative/temporary solution.

@henrikingo

This comment has been minimized.

Show comment
Hide comment
@henrikingo

henrikingo Dec 4, 2017

Contributor

@csicar I'm trying to re-read this thread to understand...

Is the problem here that you would want to add class="step" directly to an svg object? Why can't you have a div first, then the svg object inside it?

Contributor

henrikingo commented Dec 4, 2017

@csicar I'm trying to re-read this thread to understand...

Is the problem here that you would want to add class="step" directly to an svg object? Why can't you have a div first, then the svg object inside it?

@csicar

This comment has been minimized.

Show comment
Hide comment
@csicar

csicar Dec 5, 2017

The reason for having class=step inside svg is, that it would allow you to create the svg file in an external tool, like inkscape. Inkscape allows you to modify the svg-xml with a build-in editor

csicar commented Dec 5, 2017

The reason for having class=step inside svg is, that it would allow you to create the svg file in an external tool, like inkscape. Inkscape allows you to modify the svg-xml with a build-in editor

@henrikingo

This comment has been minimized.

Show comment
Hide comment
@henrikingo

henrikingo Dec 5, 2017

Contributor

Ah, that sounds interesting indeed. I think I should look into that myself one day!

FWIW, the patch you've proposed here could now easily be implemented as a plugin. It could be simply called src/plugins/svg.

Contributor

henrikingo commented Dec 5, 2017

Ah, that sounds interesting indeed. I think I should look into that myself one day!

FWIW, the patch you've proposed here could now easily be implemented as a plugin. It could be simply called src/plugins/svg.

@henrikingo

This comment has been minimized.

Show comment
Hide comment
@henrikingo

henrikingo Jan 14, 2018

Contributor

Hi @csicar

Could you share an example of where you use impress.js over an svg presentation? (presumably together with the above code.) I think your proposal to support svg makes sense, but I'd want to see it working myself in order to commit this code (as a plugin)

Contributor

henrikingo commented Jan 14, 2018

Hi @csicar

Could you share an example of where you use impress.js over an svg presentation? (presumably together with the above code.) I think your proposal to support svg makes sense, but I'd want to see it working myself in order to commit this code (as a plugin)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment