Added powerpoint 'b' functionality to insta-hide the screen #372

Open
wants to merge 1 commit into
from

Projects

None yet

3 participants

@Strikeskids

Hiding is automatically removed by switching to a new slide. This allows the presenter to go on tangents, returning focus to them instead of the irrelevant slides

@FagnerMartinsBrack
impress.js member
FagnerMartinsBrack commented Feb 7, 2016 edited

Hi @Strikeskids, in an effort to clear up older issues/PRs we are pinging back to know if you are still tracking this request.

To give a little bit of context, recently a decision was made in the project to make the development more active and the first task is to clear up older PRs like this one to see if the OP is still interested in keep it going.

@Strikeskids

I'm not emotionally attached to this change, but it would be nice to have this functionality in impress.

@FagnerMartinsBrack
impress.js member

But are you willing to change in the PR, like rebasing into master and solve conflicts, if the need arises?

@Strikeskids

Sure. I can do that. Let me know if you need me to.

@FagnerMartinsBrack
impress.js member

Thanks, we will revisit this PR later and will let you know 👍

@FagnerMartinsBrack
impress.js member

@Strikeskids Can you please provide a visual example of how this feature works and why it should be included in impress.js with 1 or 2 steps for simplicity?

For a visual example, I recommend using LICECap to record the screen in a gif format and upload as a comment here (external links can break after some time).

For the "why" part I recommend stating a real use case in which this feature is useful in a way that it cannot be done outside impress.js.

@Strikeskids

This is useful for when you are giving a talk and would like to directly engage with your audience. By clearing the screen, you remove the visuals as a distraction and get the audience to focus directly on you.

powerpoint b functionality

@Strikeskids Strikeskids Add powerpoint 'b' functionality to insta-hide the screen
Hiding is automatically removed by switching to a new slide. This allows
the presenter to go on tangents, returning focus to them instead of the
irrelevant slides.
7e93df3
@Strikeskids

Rebased onto master to merge cleanly.

@FagnerMartinsBrack
impress.js member

Rebased onto master to merge cleanly.

Thank you, but we will probably only land this once a proper test structure is setup, because this feature will require a regression testing :). We will let you know.

@henrikingo henrikingo added a commit to henrikingo/impress.js that referenced this pull request Aug 2, 2016
@Strikeskids Strikeskids Adding blackout plugin.
Press 'b' to hide / unhide presentation content.
impress#372
6f05ad0
@henrikingo

Hi @Strikeskids

In my repo, I've now added your code as its own plugin. Please have a look.

I made 1 small addition: if you press b again, it will unhide the content. Unfortunately this only works with Chrome. Firefox will for some reason not re-render the empty screen until there's a transition to next slide (which is how your original code works, and is also still there).

Thanks for a cool contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment