Correct scale depend on window's size. #62

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@presidento

With this commit an impress presentation will be the same using a small laptop or a big monitor.

You can test it at http://farkas-mate.hu/2012/impress-js/
Hint: try to resize the window, and try very different aspect ratios, too.

(This is a better version of the pull request #59: it works better with different aspect ratios.)

@presidento presidento Correct scale depend on window's size.
With this commit an impress presentation will be
the same using a small laptop or a big monitor.
d7c5888
@gengkev

combine if's?

Owner

You can join them:

// selected element is not defined as a step
// or it is already active (but select can be forced)
if ( !el || !el.stepData || el == active && !force ) {

I think, it is harder to understand the combined if, it requires more comments in the code. And you must know that the operator && has bigger precedence that the operator ||, so I think it is wiser to split these different cases.

@x3ro
x3ro commented Jan 24, 2012

+1 This would be pretty useful, especially if, for example, you are creating a presentation and you don't know what resolution the beamer will have, etc.

@bartaz
Member
bartaz commented Mar 8, 2012

I wasn't able to merge your pull request at this point, so I have added it myself based on your code.
It should already be available on demo page.

Thanks!

@bartaz bartaz closed this Mar 8, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment