Re-add "Fix Grpc-Message decoding (#117)" #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9df9c0a.
|
Looks like |
| return src | ||
| } | ||
| } else { | ||
| return "" |
There was a problem hiding this comment.
Is there a reason to return empty string here instead of null or undefined (undefined was the previous behaviour)?
Appreciate that this is likely just opinion, but this is a subtle API change and the reason this PR is currently failing tests.
There was a problem hiding this comment.
I chose an empty string because otherwise it violates the typing.
MarcusLongmuir
approved these changes
Apr 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-adds commit 9df9c0a.
@ishitatsuyuki Had to revert the change from #117 due to a breaking build. Will use this PR going forward.