Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backend_backoff_max_delay flag to grpcwebproxy #278

Merged

Conversation

@fordhurley
Copy link
Contributor

@fordhurley fordhurley commented Nov 7, 2018

Closes #277.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Thanks for the submission! Just a tiny nit pick (I need to justify my existence, right?)

opt = append(opt, grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(*flagMaxCallRecvMsgSize)))
opt = append(opt, grpc.WithBackoffMaxDelay(*flagBackendBackoffMaxDelay))

This comment has been minimized.

@johanbrandhorst

johanbrandhorst Nov 7, 2018
Collaborator

These two can just go in the same append call:

opt = append(opt,
     grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(*flagMaxCallRecvMsgSize)),
     grpc.WithBackoffMaxDelay(*flagBackendBackoffMaxDelay),
)
@johanbrandhorst
Copy link
Collaborator

@johanbrandhorst johanbrandhorst commented Nov 7, 2018

Nice work! I'll merge it after the tests have passed.

@johanbrandhorst
Copy link
Collaborator

@johanbrandhorst johanbrandhorst commented Nov 8, 2018

Rerunning the failed tests in case they were flakes.

@johanbrandhorst johanbrandhorst merged commit fdebee8 into improbable-eng:master Nov 8, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@johanbrandhorst
Copy link
Collaborator

@johanbrandhorst johanbrandhorst commented Nov 8, 2018

Thanks for your contribution!

@fordhurley
Copy link
Contributor Author

@fordhurley fordhurley commented Nov 8, 2018

Awesome! Thank you!

@fordhurley fordhurley deleted the uplevel-technology:backoff-max-delay branch Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants