Add backend_backoff_max_delay flag to grpcwebproxy#278
Merged
johanbrandhorst merged 2 commits intoNov 8, 2018
Conversation
johanbrandhorst
suggested changes
Nov 7, 2018
johanbrandhorst
left a comment
johanbrandhorst
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the submission! Just a tiny nit pick (I need to justify my existence, right?)
| } | ||
|
|
||
| opt = append(opt, grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(*flagMaxCallRecvMsgSize))) | ||
| opt = append(opt, grpc.WithBackoffMaxDelay(*flagBackendBackoffMaxDelay)) |
Contributor
There was a problem hiding this comment.
These two can just go in the same append call:
opt = append(opt,
grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(*flagMaxCallRecvMsgSize)),
grpc.WithBackoffMaxDelay(*flagBackendBackoffMaxDelay),
)
johanbrandhorst
approved these changes
Nov 7, 2018
Contributor
|
Nice work! I'll merge it after the tests have passed. |
Contributor
|
Rerunning the failed tests in case they were flakes. |
Contributor
|
Thanks for your contribution! |
Contributor
Author
|
Awesome! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #277.