Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Bazel Installation during Travis Build #122

Merged
merged 4 commits into from Oct 14, 2018

Conversation

jonnyreeves
Copy link
Contributor

No description provided.

Copy link
Contributor

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, one minor nit.

.travis.yml Outdated
@@ -31,8 +31,11 @@ cache:
directories:
- node_modules
before_install:
- wget https://github.com/bazelbuild/bazel/releases/download/0.11.0/bazel_0.11.0-linux-x86_64.deb
- sudo dpkg -i bazel_0.11.0-linux-x86_64.deb
- BAZEL_VERSION=0.11.0 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to use the list style yaml for these? Ie.

- BAZEL_VERSION=...
- wget https://github.com/bazelbuild/bazel/releases/download/${BAZEL_VERSION}/${BAZEL_DEB}
- sudo dpkg -i ${BAZEL_DEB}
- rm ${BAZEL_DEB}

It makes a bit easier to follow what is going on

@jonnyreeves jonnyreeves merged commit d9ec484 into master Oct 14, 2018
@jonnyreeves jonnyreeves deleted the cleanup-bazel-installation branch October 14, 2018 11:22
coltonmorris pushed a commit to coltonmorris/ts-protoc-gen that referenced this pull request Oct 17, 2018
* upstream/master:
  Transport member of ServiceClientOptions should be optional (improbable-eng#125)
  Allow canceling unary calls (improbable-eng#124)
  CI should check that generated code has been committed (improbable-eng#127)
  Bumped to v0.7.8-pre (improbable-eng#123)
  Prepare 0.7.7 release (improbable-eng#112)
  Clean up Bazel Installation during Travis Build (improbable-eng#122)
  Don't deploy .deb files to npm (improbable-eng#121)
  Fix snake_cased oneof message are generated to incorrect types (improbable-eng#118)
  Make ServiceError optionally null (improbable-eng#116)
  Be explicit about the need for a CommonJS environment. (improbable-eng#108)
  Replace usage of `Object.assign` (improbable-eng#110)
  Add hint for Windows users (improbable-eng#107)
  Collapse Bazel Instructions in README (improbable-eng#106)
  Implement Client Streaming and BiDi Streaming for grpc-web (improbable-eng#82)
  Add support for jstype annotation (improbable-eng#104)
chrisgervang pushed a commit to chrisgervang/flowtype-protoc-gen that referenced this pull request Nov 14, 2018
* Clean up Bazel Installation during Travis Build

* Fixup build steps

* Remove trailing slashes

* Remove bazel deb :P
chrisgervang added a commit to chrisgervang/flowtype-protoc-gen that referenced this pull request Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants