Permalink
Browse files

Just adding a TODO.

  • Loading branch information...
1 parent 7772e9e commit f1d82b1deb654cce599be8e58a15bf13138aabb1 @onefang onefang committed Mar 10, 2012
Showing with 1 addition and 0 deletions.
  1. +1 −0 linden/indra/newview/hippoupdate.cpp
@@ -18,6 +18,7 @@
std::string gHippoChannel;
+// TODO - Um, WTH? Is this actually used anywhere?
// static
bool HippoUpdate::checkUpdate()
{

8 comments on commit f1d82b1

Member

ArminW replied Mar 21, 2012

I opt (for years) for removing it - it does at least nothing for us.

Member

onefang replied Mar 21, 2012

Even worse, it does not work. As it is, it tries to open your MAC as a URL, which fails for obvious reasons.

Owner

mccabe replied Mar 22, 2012

I honestly don't think I've even looked at this file until now.

Member

ArminW replied Mar 22, 2012

its disabled somewhere anyway - long ago - probably in llstartup or llappviewer. Its purpose was to update the Hippo Viewer - in no way Imprudence did or would ever want it to do.

Member

onefang replied Mar 22, 2012

Actually, still getting a warning on startup that CURL can't connect to something that looks like a MAC which I suspect this code is doing. I'll track it down later and remove it and this file.

Member

ArminW replied Mar 22, 2012

I grepped for it, there is an #include in llappviewer.cpp however not in any cmake file - so its not compiled and also obviously nowhere used. Your CURL error must be from something else.

Member

onefang replied Mar 22, 2012

Away goes this file then.

Member

ArminW replied Mar 22, 2012

\o/

Please sign in to comment.