data-at2x attribute overridden by is_external()

[jxpx777]

We discovered that RetinaJS wasn't working for us on our production server. Eventually, we discovered it was because our site uses SSL for all pages and we use CloudFront, also over SSL, for our asset host.

I was surprised to find that check_2x_variant was called even though, since we have data-at2x attribute, this.perform_check is set to false. I believe that this else if statement should be before the check for is_external() in order to avoid this issue. If the markup specifies the data-at2x, RetinaJS should short circuit IMHO to simply use the value specified and not do any other checking whatsoever.

[heygambo]

+1 you made my day!

just swaped the conditions:

    if (!this.perform_check && typeof this.at_2x_path !== "undefined" && this.at_2x_path !== null) {
      return callback(true);
    } else if (this.is_external()) {
      return callback(false);