Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for TLS #9

Merged
merged 5 commits into from Mar 22, 2019

Conversation

Projects
None yet
3 participants
@walmon
Copy link
Contributor

commented Mar 13, 2019

Hi. I saw you are contributing your code to Hyperledger. I'm one of the maintainers of Convector, an Hyperledger Labs incubated project for smart contracts in JavaScript. Great work! Looks and feels pretty neat.

I tried it and saw that it didn't support TLS yet. I implemented the support for it.

Basically now there are 3 optional vars to include the PEM for the peer, the network profile for the TLS certs and addresses, and one for SSL OVERRIDE.

This shouldn't affect non-TLS networks.

Tested it out in a Hyperledger Fabric 1.4 network.

walmon added some commits Mar 13, 2019

feat: ignore .history folder vscode and .env root
Signed-off-by: walmon <walmon93@hotmail.com>
docs: instructions for TLS
Signed-off-by: walmon <walmon93@hotmail.com>
feat: plumbing for TLS
Signed-off-by: walmon <walmon93@hotmail.com>
fix: no env vars were loaded
Signed-off-by: walmon <walmon93@hotmail.com>
fix: read json net profile
Signed-off-by: walmon <walmon93@hotmail.com>
@dpitt

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

Thanks for the pull request, will check it out and apply. David

@peterhle
Copy link

left a comment

+1 @walmon I have reviewed and tested on both with TLS and non-TLS. thanks

@peterhle peterhle merged commit 20ca65a into in-the-keyhole:master Mar 22, 2019

@peterhle

This comment has been minimized.

Copy link

commented Mar 22, 2019

@walmon thanks for the contribution. We've merged the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.