Integrate in-toto (link attestations) with rebuilderd - #1
Conversation
|
Updated the base branch to avoid merge littering when we want to upstream it later. |
|
Marked this as ready for review based on the demo today, @joyliu-q. I'm going to take a look at it in a bit, do you have anything to push up to this one? 😄 |
adityasaky
left a comment
There was a problem hiding this comment.
This looks great, @joyliu-q, excellent work! I have some minor nits. Please note as a rule of thumb that it's better to keep the changes in a PR strictly related to the subject at hand. I think some formatting changes have crept in here, and they can litter the history of those lines of code.
SantiagoTorres
left a comment
There was a problem hiding this comment.
LGTM, modulo two very small nits!
adityasaky
left a comment
There was a problem hiding this comment.
LGTM, save the as yet open comments about autoformatting + in-toto version in the manifest. Great work, @joyliu-q!
439e0d7 to
602ee27
Compare
602ee27 to
6ee44d4
Compare
adityasaky
left a comment
There was a problem hiding this comment.
LGTM again, @joyliu-q, thanks for cleaning up the history :)
The following PR is part of the Google Summer of Code 2021 program.
The in-toto GSoC project is to develop in-toto-rs capabilities to support rebuilderd (Issue in-toto/in-toto-rs#4), which includes two parts:
runlib.rs; implement link generation usingin_toto_run.in_toto_runand link generation within rebuilderd.This PR addresses part 2.
Features
rebuilderd.dbwith SQL migrations (addhas_attestationfield topackages, removeattestationfield frompackages, and addattestationtobuildsto store link attestation)in_toto_runfunction to run and generate link attestation based on rebuild with contextual link nameattestationandhas_attestationin DB whenBuildis good