New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React Native 0.40.x header imports #104

Merged
merged 3 commits into from Feb 8, 2017

Conversation

Projects
None yet
8 participants
@georgiana-gligor
Contributor

georgiana-gligor commented Jan 26, 2017

@andon

This comment has been minimized.

andon commented Jan 29, 2017

Better if the library continues to work with RN < 0.40:
https://twitter.com/atticoos/status/825435275887276033

@max-mykhailenko max-mykhailenko referenced this pull request Jan 30, 2017

Closed

fix RN 0.40 build #107

@max-mykhailenko

This comment has been minimized.

max-mykhailenko commented Jan 30, 2017

@georgiana-gligor please fix compatibility

@georgiana-gligor

This comment has been minimized.

Contributor

georgiana-gligor commented Jan 30, 2017

Hi @max-mykhailenko I'm not sure I completely understand what you mean. Do you refer to setting "version": "0.9.0" in package.json instead of 0.8.1`? Or do you mean something completely different?

@max-mykhailenko

This comment has been minimized.

max-mykhailenko commented Jan 30, 2017

@georgiana-gligor @andon told that better don't remove compatibility and code example for this
https://pbs.twimg.com/media/C3SI8N-W8AAPP89.jpg:large

@georgiana-gligor

This comment has been minimized.

Contributor

georgiana-gligor commented Jan 30, 2017

Thank you for the patience @max-mykhailenko . I have updated the pull request to reflect this.

@wcandillon

This comment has been minimized.

Contributor

wcandillon commented Jan 30, 2017

I tried this PR and it seems to be working great 🎉

@max-mykhailenko

This comment has been minimized.

max-mykhailenko commented Jan 31, 2017

Who can release this?

@max-mykhailenko

This comment has been minimized.

max-mykhailenko commented Feb 8, 2017

@paramaggarwal please release this PR

@jujumoz

This comment has been minimized.

Contributor

jujumoz commented Feb 8, 2017

Can you just resolve the conflicts by yourself before I merge it ? thanks !

@jujumoz jujumoz merged commit 959cc82 into inProgress-team:master Feb 8, 2017

@salmankhann

This comment has been minimized.

Contributor

salmankhann commented Feb 12, 2017

@jujumoz could you release 0.8.1 to npm?

@jujumoz

This comment has been minimized.

Contributor

jujumoz commented Feb 12, 2017

@salmankhann done !

@salmankhann

This comment has been minimized.

Contributor

salmankhann commented Feb 13, 2017

@jujumoz there seems to be a problem because the latest version on npm is still 0.8.0. Could you please check?

@max-mykhailenko

This comment has been minimized.

max-mykhailenko commented Feb 13, 2017

@jujumoz have same problem, don't see 0.8.1 on npm

@Naoto-Ida

This comment has been minimized.

Naoto-Ida commented Feb 16, 2017

I still can't see it with npm view react-native-youtube versions.

@rdougan

This comment has been minimized.

rdougan commented Feb 17, 2017

@jujumoz still not released. I don't see the 0.8.1 tag - perhaps that is why?

@jujumoz

This comment has been minimized.

Contributor

jujumoz commented Feb 20, 2017

@max-mykhailenko , @Naoto-Ida , @rdougan , it should be working now, I published 0.8.1 on npm. ;)
Keep me in touch and sorry for the delay.
If anyone has time to update the README, please feel free !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment