New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

‘Ignored variable is being used’ reported for non-variables #409

Open
ddeboer opened this Issue Oct 18, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@ddeboer

ddeboer commented Oct 18, 2016

First off, thanks for Elvis! It’s a great tool for keeping an eye on code quality.

The is_ignored_var check apparently reports this macro call as a ignored variable as well:

?__("This string will be translated. This is a common convention that we also use in the Zotonic framework."),

Can the check be adapted to exclude macros?

@JohanVikman

This comment has been minimized.

Show comment
Hide comment
@JohanVikman

JohanVikman Oct 19, 2017

Contributor

@elbrujohalcon do we need to update katana for this? If katana could show that this is a macro it would be easier to fix this in elvis_core I think...

Contributor

JohanVikman commented Oct 19, 2017

@elbrujohalcon do we need to update katana for this? If katana could show that this is a macro it would be easier to fix this in elvis_core I think...

@elbrujohalcon

This comment has been minimized.

Show comment
Hide comment
@elbrujohalcon

elbrujohalcon Oct 19, 2017

Member

@JohanVikman probably, since the code seems to be already verifying that it's in fact a variable here.
If this bug is still happening (maybe it's already fixed), it's probably a katana-code bug and it should be reported as such.

Member

elbrujohalcon commented Oct 19, 2017

@JohanVikman probably, since the code seems to be already verifying that it's in fact a variable here.
If this bug is still happening (maybe it's already fixed), it's probably a katana-code bug and it should be reported as such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment