New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add expressions for retrieving each sections of report #4986

Merged
merged 4 commits into from May 14, 2018

Conversation

Projects
None yet
1 participant
@myarjunar
Collaborator

myarjunar commented May 4, 2018

What does it fix?

  • Ticket: fix #4964
  • Funded by: DFAT
  • Description:
    • we are separating the analysis summary report into expression per section

Checklist:

  • Commit messages are descriptive and explain the rationale for changes
  • Add to the changelog in metadata.txt if it's a new feature
  • Unit test for new code added
  • Request someone to review or test your PR

@myarjunar myarjunar requested a review from ismailsunni May 4, 2018

@myarjunar

This comment has been minimized.

Collaborator

myarjunar commented May 9, 2018

can someone disable/approve codeclimate here? cc @ismailsunni @lucernae

@myarjunar

This comment has been minimized.

Collaborator

myarjunar commented May 14, 2018

I'm gonna merge this since it's only failing on codeclimate and the error is not relevant

@myarjunar myarjunar merged commit 5f416f7 into inasafe:develop May 14, 2018

2 of 3 checks passed

codeclimate 11 issues to fix
Details
ci/sideci No issues found!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@myarjunar myarjunar removed the Needs review label May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment