Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add expressions for retrieving each sections of report #4986

merged 4 commits into from May 14, 2018


Copy link

@myarjunar myarjunar commented May 4, 2018

What does it fix?

  • Ticket: fix #4964
  • Funded by: DFAT
  • Description:
    • we are separating the analysis summary report into expression per section


  • Commit messages are descriptive and explain the rationale for changes
  • Add to the changelog in metadata.txt if it's a new feature
  • Unit test for new code added
  • Request someone to review or test your PR
@myarjunar myarjunar requested a review from ismailsunni May 4, 2018
@myarjunar myarjunar force-pushed the myarjunar:realtime-expression branch from b628b0f to c86d2ca May 4, 2018
Copy link
Collaborator Author

@myarjunar myarjunar commented May 9, 2018

can someone disable/approve codeclimate here? cc @ismailsunni @lucernae

Copy link
Collaborator Author

@myarjunar myarjunar commented May 14, 2018

I'm gonna merge this since it's only failing on codeclimate and the error is not relevant

@myarjunar myarjunar merged commit 5f416f7 into inasafe:develop May 14, 2018
2 of 3 checks passed
2 of 3 checks passed
codeclimate 11 issues to fix
ci/sideci No issues found!
continuous-integration/travis-ci/pr The Travis CI build passed
@myarjunar myarjunar removed the Needs review label May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant