Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Removing taxon_id from list should delete in_taxon list rule, not just remove operand_id #227

Open
loarie opened this Issue Feb 8, 2014 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

loarie commented Feb 8, 2014

Removing the higher-level-taxon from a list:
e.g. http://www.inaturalist.org/check_lists/63646-California-Carnivorans/edit
sets the list.taxon_id and the operand_id in the associated in_taxon list rule to nil, but this subsequently makes 'Add to List' validations fail on (e.g. on http://www.inaturalist.org/check_lists/63646-California-Carnivorans'Lion (Panthera leo) is not in taxon').

Removing the taxon_id from a list should remove the associated in_taxon list_rule or validations should ignore in_taxon list rules when operand_id is nil. Which is a better/easier fix?

Owner

kueda commented Feb 8, 2014

Removing the rule would be better. No reason to have rules that don't do anything other than cause validation failure.

Contributor

loarie commented Nov 5, 2015

Ok - issue remains, plan is to remove rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment