Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifier not displayed on Nightly #436

Closed
qzgy opened this issue Nov 24, 2016 · 4 comments
Closed

Notifier not displayed on Nightly #436

qzgy opened this issue Nov 24, 2016 · 4 comments

Comments

@qzgy
Copy link

@qzgy qzgy commented Nov 24, 2016

The notifier is not being displayed anywhere with the plugin installed on the newest nightly build.

@floppyrom
Copy link

@floppyrom floppyrom commented Nov 26, 2016

Same problem on Nightly 53.0a1 (2016-11-25) (64-bit)

@Matth7878
Copy link

@Matth7878 Matth7878 commented Dec 10, 2016

Do not know how to push to github but to fix it it is what I did :

  • opened xpi to edit app.js (in lib\wrapper\firefox)
  • replaced line 232 : "for each (var tab in tbs) {" with "for (var tab of tbs) {"
  • same for line 476 : "for each (var tab in tbs) {" with "for (var tab of tbs) {"

Edit : I think I did succeed to push a pull request (hope I did nothing wrong), see #438

@inbasic
Copy link
Owner

@inbasic inbasic commented Dec 10, 2016

Thanks for the report. Version 0.7.0 which is already submitted for review fixes this issue.

@inbasic inbasic closed this Dec 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants