decomp-svd returns diagonal of matrix, not diagonal matrix #66

Closed
ejackson opened this Issue Mar 15, 2012 · 1 comment

2 participants

@ejackson

In the SVD rather than returning S as a diagonal matrix, per the docs and behaviour of Colt, the diagonal of that matrix is returned as a vector. See

https://github.com/liebke/incanter/blob/master/modules/incanter-core/src/incanter/core.clj#L899

The patch is just to remove the call to (diag ...) and I'm happy to submit it if we're agreed that this is the sensible behaviour.

@alexott

This is already fixed in 1.5.0-SNAPSHOT, where we switched to clatrix

@alexott alexott closed this May 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment