Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2285 - Enable wicket CSP #2298

Closed
wants to merge 13 commits into from
Closed

Conversation

reckart
Copy link
Member

@reckart reckart commented May 22, 2021

What's in the PR

  • Enable CSP features in Wicket

How to test manually

  • ...

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Turning CSP up to the first notch - and of course it breaks stuff we now have to see how to get fixed
* master: (45 commits)
  #2046 - List logged events with spring websockets
  #2111 - Replace okhttp in external recommender with Java HTTP client
  #2264 - Risk of permanently unfinished documents using dynamic workflow
  #2293 - Clicking on the dropdown in the export menu from the annotation editor logs error
  No issue. Fix issue that the wrong target was used in confirmation dialog callback.
  #2264 - Risk of permanently unfinished documents using dynamic workflow
  #2264 - Risk of permanently unfinished documents using dynamic workflow
  No issue. Move order annotations into bean classes, otherwise the registries cannot pick them up when sorting by order.
  No issue. Handle long error messages by word-wrapping.
  No issue. Choose better name for the initialize method.
  #2276 - More Spring auto-configuration
  #2276 - More Spring auto-configuration
  #2276 - More Spring auto-configuration
  #2276 - More Spring auto-configuration
  #2276 - More Spring auto-configuration
  #2264 - Risk of permanently unfinished documents using dynamic workflow
  #2264 - Risk of permanently unfinished documents using dynamic workflow
  #2264 - Risk of permanently unfinished documents using dynamic workflow
  #2046 - List logged events with spring websockets
  #2046 List logged events with spring websockets
  ...
@reckart reckart added the ⭐️ Enhancement New feature or request label May 22, 2021
@reckart reckart added this to the 0.21.0 milestone May 22, 2021
@reckart reckart self-assigned this May 22, 2021
@reckart reckart added this to 🏃‍♀️ In progress in Kanban via automation May 22, 2021
* master: (26 commits)
  #2295 - Links to user guide do not work
  #2295 - Links to user guide do not work
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-0.19.4
  #2294 - Hide recent activity for annotators in dynamic projects
  #2186 - Support per-project guest annotators
  #1634 - Explicit UI for accepting/rejecting recommendations
  #2243 - Directly select tags for small tagsets
  #2297 - Description popups tend to be smallish
  #2295 Links to user guide do not work
  #2293 - Clicking on the dropdown in the export menu from the annotation editor logs error
  No issue: Remove gitattributes to allow merge
  #1634 - Explicit UI for accepting/rejecting recommendations
  #1634 - Explicit UI for accepting/rejecting recommendations
  #1634 - Explicit UI for accepting/rejecting recommendations
  #1697 - More explicit UI for accepting/rejecting recommender suggestinons - feature for INCEpTION
  #1634 - Explicit UI for accepting/rejecting recommendations
  #1697 - More explicit UI for accepting/rejecting recommender suggestinons - feature for INCEpTION - Added AcceptActionResponse - Added RejectActionResponse
  #1697 - More explicit UI for accepting/rejecting recommender suggestons - feature for INCEpTION
  #1697 - More explicit UI for accepting/rejecting recommender suggestons - feature for INCEpTION
  ...
@reckart reckart marked this pull request as draft June 5, 2021 22:30
* master:
  #2399 - Sentence overview wrongly indicates agreement
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-0.20.0-rc-1
  #2337 - Update user guide on recommendation sidebar
  #2286 - Upgrade dependencies
  #2310 - Tutorial UI elements sometimes clog up in top-left corner
  #2310 - Tutorial UI elements sometimes clog up in top-left corner
  #2392 - Deleting a project does not remove the KBs
  #2390 - More fine-grained info during startup
  #2392 - Deleting a project does not remove the KBs
  #2390 - More fine-grained info during startup
  #2390 - More fine-grained info during startup
  #2390 - More fine-grained info during startup
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-0.19.7
@reckart reckart changed the title Feature/2285 enable wicket csp #2285 - Enable wicket CSP Jun 22, 2021
…able-Wicket-CSP

* refactoring/2404-Fix-CSP-blockers:
  #2404 - Fix CSP blockers
…able-Wicket-CSP

* refactoring/2404-Fix-CSP-blockers:
  #2404 - Fix CSP blockers
  #2405 - Chrome warns about deprecation in July 2021
  #2404 - Fix CSP blockers
- Disable CSP but enable reporting at the level at which Kendo sets up CSP (in development mode)
@reckart reckart modified the milestones: 0.21.0, ⭐️ Feature backlog Jul 6, 2021
@reckart
Copy link
Member Author

reckart commented Jul 22, 2021

CSP is enabled as much as currently possible, the issue with vue has been addressed otherwise - so this is not imminent anymore. Closing.

@reckart reckart closed this Jul 22, 2021
Kanban automation moved this from 🏃‍♀️ In progress to 🍹 Done Jul 22, 2021
@reckart reckart removed this from the ⭐️ Feature backlog milestone Jul 22, 2021
@reckart reckart removed this from 🍹 Done in Kanban Jul 22, 2021
@reckart reckart added 🗑️ Wontfix This will not be worked on and removed ⭐️ Enhancement New feature or request labels Jul 22, 2021
@reckart reckart deleted the feature/2285-Enable-Wicket-CSP branch July 22, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗑️ Wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant