New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the SQL Server-specific mapping (DocumentAbstract-sqlserver.orm) for DocumentAbstract's clobChars #24

Closed
danhaywood opened this Issue Mar 30, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@danhaywood
Contributor

danhaywood commented Mar 30, 2017

originally this issue was raised to change the mapping for SQL Server from text to ntext, with corresponding change in mapping of LONGVARCHAR to LONGNVARCHAR (to avoid character encoding issues).

However, as of DN 4.1.7 (in Apache Isis 1.14.0), LONGNVARCHAR does not seem to be supported, either for sql-type or jdbc-tye.

And in general I can't find any way to map correctly to either ntext or nvarchar(max).

For my own use case (Estatio) we are using isis-module-flyway to manage database schema, and so mapping the .orm just to specify the length (with no jdbc-type or sql-type) seems to work ok so long as the table has been created externally. It doesn't work however to auto-create the table.

Therefore, think there is no all purpose solution to this. Best option for now is to let the consuming application (if using SQL Server) provide their own .orm file.

@danhaywood danhaywood changed the title from change SQLServer ORM mapping to use ntext rather than text for DocumentAbstract's clob_chars to remove the SQL Server-specific mapping for DocumentAbstract's clobChars Mar 30, 2017

@danhaywood danhaywood changed the title from remove the SQL Server-specific mapping for DocumentAbstract's clobChars to remove the SQL Server-specific mapping (DocumentAbstract-sqlserver.orm) for DocumentAbstract's clobChars Mar 30, 2017

danhaywood added a commit that referenced this issue Mar 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment