Miscellaneous fixes #799
Merged
Miscellaneous fixes #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 27, 2022 18:36
Certain loop variables were unscoped, and thereby becoming global; also, a per-level variable (bannedGroup) was not scoped in certain places to the corresponding level object, thus becoming global as well.
(The rules property is an array of arrays, but was getting copied as if it was an array of ordinary data.)
The tokenIndex was being set to 1 for level messages, so the comment handler remained active. This could cause strange behavior if the message began with a '('.
increpare
approved these changes
Feb 21, 2022
Owner
increpare
left a comment
increpare
left a comment
There was a problem hiding this comment.
Thanks a lot of these - some nice spring-cleaning. (I'll change the level.bannedgroup thing to just be a local var though)
increpare
added a commit
that referenced
this pull request
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fix miscellaneous code issues:
(See the commits for more precise details.)