-
-
Notifications
You must be signed in to change notification settings - Fork 170
Fix the compile process #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Why is it important to use the commonjs version? (note to future self: otherwise this PR is good 👍 ) |
Removing specific version of gifsicle (gifsicle@5.3.0) because I didn't understand why it was specified.
|
That's to fix the error I get when I take the latest version of gifsicle and run |
|
Oh gosh, yeah. I was having packages getting cached locally in a very stubborn way. Yeah, let's keep with the legacy module system for now :) Thanks for the reply! |
…ing me an out of memory error for some reason
|
Should I delete my branch? I've noticed that only the top point I listed above got committed yet. |
|
Oh right huh, thanks for giving me a poke even though the issue was closed.
I've made the remaining changes by hand right now. Yes you can delete it if you wish :) |
|
Cool! Now I'm able to compile without issues. Although, I must say, the typo now reads "stadalone" :) |
commit a625116 Merge: db646ab e08f117 Author: david <davidb@pfxcorp.com> Date: Sat Mar 4 18:24:37 2023 +1100 Merge remote-tracking branch 'remotes/increpare/master' into tomerge 135fb61 7/3/22 Minor changes to pass all tests Minor changes to tests.js, for test selection # Conflicts fixed: # .build/buildnumber.txt # .gitignore # README.md # src/Documentation/css/bootstrap-theme.css # src/Documentation/levels.html # src/Documentation/prelude.html # src/Documentation/rigidbodies.html # src/css/toolbar.css # src/demo/constellationz.txt # src/demo/kettle.txt # src/demo/leftrightnpcs.txt # src/demo/midas.txt # src/demo/octat.txt # src/demo/rigid_scott1.txt # src/demo/rigidfail1.txt # src/demo/whaleworld.txt # src/demo/zenpuzzlegarden.txt # src/js/compiler.js # src/js/debug.js # src/js/debug_off.js # src/js/engine.js # src/js/inputoutput.js # src/js/parser.js # src/js/sfxr.js # src/js/soundbar.js # src/tests/resources/testdata.js # src/tests/resources/tests.js # src/tests/tests.html commit db646ab Author: david <davidb@pfxcorp.com> Date: Thu Mar 2 16:41:38 2023 +1100 New games_dat_plus for PS+ gallery Fix message parsing to match new PS+ Fix missing PS+ commands commit f01d20c Merge: 6b81a37 a35bf83 Author: david <davidb@pfxcorp.com> Date: Wed Mar 1 18:58:04 2023 +1100 Merge commit 'a35bf83483c7853a025a45983412c2b84e04d2ac' into tomerge Conflicts resolved: # src/demo/blank.txt # src/demo/blockfaker.txt # src/demo/byyourside.txt # src/demo/constellationz.txt # src/demo/kettle.txt # src/demo/limerick.txt # src/demo/microban.txt # src/demo/midas.txt # src/demo/naughtysprite.txt # src/demo/nekopuzzle.txt # src/demo/notsnake.txt # src/demo/octat.txt # src/demo/randomrobots.txt # src/demo/randomspawner.txt # src/demo/sokoban_eyeball.txt # src/demo/sokoban_horizontal.txt # src/demo/sokoban_match3.txt # src/demo/sokoban_sticky.txt # src/demo/sumo.txt # src/demo/whaleworld.txt # src/demo/zenpuzzlegarden.txt # src/editor.html # src/js/parser.js commit 6b81a37 Author: david <davidb@pfxcorp.com> Date: Wed Mar 1 18:47:36 2023 +1100 Tweak parser PS+ comments commit 9060f9d Merge: 8ffde93 a6e18cb Author: david <davidb@pfxcorp.com> Date: Wed Mar 1 18:35:14 2023 +1100 Merge commit 'a6e18cbf14d83c4693980d593a4dee40eb11bd09' into tomerge Conflicts fixed: # compile.js # src/editor.html # src/js/gamedat.js # src/js/graphics.js # src/play.html # src/standalone.html # src/tests/resources/testdata.js commit e08f117 Author: Stephen Lavelle <analytic@gmail.com> Date: Tue Jul 26 11:06:09 2022 +0200 lol increpare/PuzzleScript#846 (comment) commit 6af3adc Author: Stephen Lavelle <analytic@gmail.com> Date: Tue Jul 26 06:40:13 2022 +0200 final bits of #846 commit 4472082 Author: increpare <analytic@gmail.com> Date: Tue Jul 26 06:13:25 2022 +0200 sandalone->standalone cf #846 commit 048bdb9 Author: Stephen Lavelle <analytic@gmail.com> Date: Fri Jul 8 16:47:07 2022 +0200 compile commit 12d10d2 Author: Stephen Lavelle <analytic@gmail.com> Date: Fri Jul 8 16:46:53 2022 +0200 sfw-izing a test that slipped through commit 597f9c4 Author: Stephen Lavelle <analytic@gmail.com> Date: Fri Jul 8 16:39:26 2022 +0200 hide scrollbar if toolbar too narrow (related to #921 ) commit c8612d8 Author: Stephen Lavelle <analytic@gmail.com> Date: Tue Jul 5 17:01:41 2022 +0200 make toolbar scrollable fixes #921 commit 3dcc07b Author: Stephen Lavelle <analytic@gmail.com> Date: Tue Jul 5 16:49:10 2022 +0200 fixes #929 commit 2b06c96 Author: Stephen Lavelle <analytic@gmail.com> Date: Fri May 6 14:20:08 2022 +0200 fixes #918 commit 74f2fcf Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 16 17:11:42 2022 +0100 caught errors get their details printed to the console (including stack trace :) ) commit 306bcc2 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 16 16:03:27 2022 +0100 fixes #904 - by your side has a warning commit e47b350 Author: Stephen Lavelle <analytic@gmail.com> Date: Tue Mar 15 17:25:46 2022 +0100 fixes #903 commit 68addb7 Merge: 132768c 9b2857a Author: increpare <analytic@gmail.com> Date: Mon Mar 14 12:55:27 2022 +0100 Merge pull request #900 from increpare/doubleellipses fixes #506 commit 9b2857a Merge: cd31159 132768c Author: increpare <analytic@gmail.com> Date: Mon Mar 14 12:55:19 2022 +0100 Merge branch 'master' into doubleellipses commit cd31159 Author: Stephen Lavelle <analytic@gmail.com> Date: Mon Mar 14 12:52:54 2022 +0100 rest of implementation for #506 with tests + mention in documentation commit 132768c Merge: ef1617e b510ee5 Author: increpare <analytic@gmail.com> Date: Sun Mar 13 06:09:32 2022 +0100 Merge pull request #899 from BentSm/sound-history-fix Added missing pushSoundToHistory function to debug_off.js commit b510ee5 Author: Ben Small <bentsm@noreply.github.com> Date: Sat Mar 12 17:17:18 2022 -0800 Added missing pushSoundToHistory function to debug_off.js (This function was referenced by sfxr.js, but was only defined in debug.js. This caused breakage when trying to play sounds outside of the editor.) commit ef1617e Merge: 6a42699 aeca8ea Author: increpare <analytic@gmail.com> Date: Sat Mar 12 04:50:58 2022 +0100 Merge pull request #898 from hcs64/master Fix non-square flickscreen/zoomscreen coordinates commit aeca8ea Author: Adam Gashlin <agashlin@gmail.com> Date: Fri Mar 11 16:02:17 2022 -0800 Fix coordinates tests commit d2bfdc3 Author: Adam Gashlin <agashlin@gmail.com> Date: Fri Mar 11 15:39:31 2022 -0800 Fix non-square flickscreen/zoomscreen coordinates Regressed in 0edceb9 commit 3d0bc3a Author: Stephen Lavelle <analytic@gmail.com> Date: Fri Mar 11 10:10:40 2022 +0100 tidying up examples (for #844) commit 30f592c Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Mar 10 18:24:49 2022 +0100 . commit 6a42699 Author: increpare <analytic@gmail.com> Date: Thu Mar 10 11:19:17 2022 +0100 Update README.md commit 07fa6e1 Merge: 42af7b4 d82482b Author: increpare <analytic@gmail.com> Date: Thu Mar 10 11:19:00 2022 +0100 Merge pull request #895 from increpare/add-license-1 Create LICENSE commit d82482b Author: increpare <analytic@gmail.com> Date: Thu Mar 10 11:18:36 2022 +0100 Create LICENSE commit 42af7b4 Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Mar 10 10:13:07 2022 +0100 fixes #128 commit aa7e91b Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Mar 10 06:54:25 2022 +0100 show the level diff commit 589a1f7 Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Mar 10 03:59:30 2022 +0100 fixes #893 commit 5e85887 Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Mar 10 03:44:47 2022 +0100 fixes #871 commit 5cc0d83 Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Mar 10 03:34:48 2022 +0100 fixes #892 commit 0b4d346 Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Mar 10 03:22:24 2022 +0100 fixes #890 commit 89c215e Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Mar 10 02:40:32 2022 +0100 Revert "update qunit 1.12.0->1.23.1" This reverts commit c30a4b2. It had an annoying behaviour of applying hashes to test cases rather than numerical ids, which is more useful for my workflow... commit 56b3246 Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Mar 10 02:19:51 2022 +0100 build commit 132039d Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Mar 10 02:19:45 2022 +0100 fixes #891 commit 9a25b49 Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Mar 10 02:01:55 2022 +0100 fixes #889, fixes #768 commit 0786c77 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 16:12:58 2022 +0100 fixes #770 commit 5eb1313 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 15:58:27 2022 +0100 Revert "code spring-cleaning - changing a bunch of VARs to CONSTs" This reverts commit 028f525. commit c30a4b2 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 15:36:51 2022 +0100 update qunit 1.12.0->1.23.1 commit 028f525 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 15:36:14 2022 +0100 code spring-cleaning - changing a bunch of VARs to CONSTs commit 072e9d0 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 15:04:42 2022 +0100 fixes #887 commit d2d7068 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 14:52:54 2022 +0100 fixes #888 commit d4ad33d Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 13:52:46 2022 +0100 fixes #797 hopefully. I can't test it with tests, it seems, for whatever reason. But it doesn't seem to have broken any other tests, at least... ALSO fixes issue with restart not displaying message if it's triggered during again commit 47ae448 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 12:40:16 2022 +0100 fixes #880 commit f73f854 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 12:30:34 2022 +0100 minor html fix commit e5eb731 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 12:30:26 2022 +0100 fixes #872 commit 1a4304f Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 04:32:16 2022 +0100 minor edit to rigidbodies.html commit 4dbe431 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 04:01:19 2022 +0100 adding final bit from #846 commit 8102102 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 02:47:49 2022 +0100 fixing link commit 67ceb51 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 02:46:11 2022 +0100 fixes #873 commit 0edceb9 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 02:15:17 2022 +0100 better checks for dimensions in flickscreen+zoomscreen commit d01458e Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 02:02:14 2022 +0100 compile commit 35dd677 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 01:48:47 2022 +0100 fixes #879 commit dc72b07 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 01:37:58 2022 +0100 fixes #883 commit 4d9f330 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 01:33:11 2022 +0100 fixes #885, fixes #886 commit 8bcb966 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Mar 9 00:49:25 2022 +0100 accepting final bit of #846 and unthreading a loop because it was giving me an out of memory error for some reason commit 14e933a Author: Stephen Lavelle <analytic@gmail.com> Date: Tue Mar 8 15:49:08 2022 +0100 fixes #877, fixes #882 commit 6705613 Author: Stephen Lavelle <analytic@gmail.com> Date: Tue Mar 8 15:36:36 2022 +0100 fixes #878 commit 9da9689 Author: Stephen Lavelle <analytic@gmail.com> Date: Tue Mar 8 15:27:52 2022 +0100 fixes #881 commit b743526 Author: Stephen Lavelle <analytic@gmail.com> Date: Tue Mar 8 15:16:42 2022 +0100 tweaking documentation commit d1cf51b Author: Stephen Lavelle <analytic@gmail.com> Date: Tue Mar 8 15:14:36 2022 +0100 Update tests.js imrpove test fail output for unit tests commit 3785927 Author: Stephen Lavelle <analytic@gmail.com> Date: Tue Mar 8 15:14:20 2022 +0100 fixes #875 in the process made a lot of new tests, and improved error message output commit 7d383f5 Author: Stephen Lavelle <analytic@gmail.com> Date: Tue Mar 8 12:15:58 2022 +0100 fixes #874 commit 3b93651 Author: Stephen Lavelle <analytic@gmail.com> Date: Tue Mar 8 03:19:43 2022 +0100 fixes #869, #870, #688, #864 fixes #870 somehow though I'm not sure how. fixes #869 fixes #870 fixes #688 fixes #864 commit 135fb61 Author: Stephen Lavelle <analytic@gmail.com> Date: Mon Mar 7 13:27:22 2022 +0100 more tests for #866 commit ffd0fdf Author: Stephen Lavelle <analytic@gmail.com> Date: Mon Mar 7 11:03:34 2022 +0100 #866 rigid applies to movements even if the objects are changed to different objects in the same layer commit 679da3f Author: Stephen Lavelle <analytic@gmail.com> Date: Mon Mar 7 11:01:33 2022 +0100 #866 rigid applies to movements even if the movements are chagned by subsequent non-rigid rules in other groups commit a63e19e Author: Stephen Lavelle <analytic@gmail.com> Date: Mon Mar 7 10:31:27 2022 +0100 test for #866 rigid applies to movements even if the movements were already present in the cell before rule application [i.e. if the rule doesn't do anything] commit 355ecf4 Author: Stephen Lavelle <analytic@gmail.com> Date: Mon Mar 7 10:22:20 2022 +0100 rigidbody test (for #866) commit 1fb5393 Author: Stephen Lavelle <analytic@gmail.com> Date: Mon Mar 7 10:20:56 2022 +0100 Delete codeql-analysis.yml Not sure what if anything it's doing - maybe I'll try it again another time, but because I'm running my own tests locally anyway, it's not likely to contribute much to my workflow. On the other hand, it might help with other people submitting patches, if I got qunit to work somehow. Hmm. Whatever. commit dab68c4 Merge: ea69b7e a5ba0eb Author: Stephen Lavelle <analytic@gmail.com> Date: Mon Mar 7 10:18:03 2022 +0100 Merge branch 'master' of https://github.com/increpare/PuzzleScript commit ea69b7e Author: Stephen Lavelle <analytic@gmail.com> Date: Mon Mar 7 10:17:50 2022 +0100 fixes #868 commit a5ba0eb Author: Stephen Lavelle <analytic@gmail.com> Date: Fri Mar 4 17:14:10 2022 +0100 fixes #863 commit 9870191 Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Mar 3 16:34:47 2022 +0100 fixes #862, fixes #843 partly dependent on #860 which I can't include right now commit 97efac7 Author: increpare <analytic@gmail.com> Date: Thu Mar 3 13:39:23 2022 +0100 fixes #859 commit ae2f0f6 Merge: a35bf83 d3f7b82 Author: increpare <analytic@gmail.com> Date: Fri Feb 25 20:38:19 2022 +0100 Merge pull request #847 from MisshapenSmiley/gitignore-fix Ignore .DS_Store in all subdirectories commit a35bf83 Author: Stephen Lavelle <analytic@gmail.com> Date: Fri Feb 25 13:08:39 2022 +0100 fixes #857 commit 964468e Author: Stephen Lavelle <analytic@gmail.com> Date: Fri Feb 25 13:03:39 2022 +0100 fixes #848 commit ddde26f Author: Stephen Lavelle <analytic@gmail.com> Date: Fri Feb 25 03:37:59 2022 +0100 fixes #829 (mostly) I'll try to add some special test (see #856 ) to monitor the exempted gist to make sure I'm notified if it changes. I think the security risk is adequately minimised by this workaround while not breaking an older + beloved game. commit 0637af0 Merge: 87c905f f70adbb Author: Stephen Lavelle <analytic@gmail.com> Date: Fri Feb 25 03:08:10 2022 +0100 Merge branch 'master' of https://github.com/increpare/PuzzleScript commit f70adbb Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Feb 24 23:40:18 2022 +0100 fixes #854 commit da0fd9e Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Feb 24 23:31:13 2022 +0100 fixes #855 commit 71a5b29 Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Feb 24 23:04:06 2022 +0100 file renaming to get around case-madness Part 2 (fixes #853 ) commit a2958d1 Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Feb 24 23:03:57 2022 +0100 file renaming to get around case-madness Part 1 (for #853 ) commit 1b935f7 Merge: c5f225a a23e124 Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Feb 24 22:37:11 2022 +0100 Merge branch 'master' of https://github.com/increpare/PuzzleScript commit c5f225a Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Feb 24 22:37:08 2022 +0100 fixing erronious explanation commit 87c905f Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Feb 24 20:55:39 2022 +0100 fixes #849 ok I'm going for lower-case on keywords commit 32b3c6a Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Feb 24 20:19:47 2022 +0100 fixes #850 commit a23e124 Author: Stephen Lavelle <analytic@gmail.com> Date: Thu Feb 24 19:23:44 2022 +0100 fixes #852 commit a6e18cb Merge: a08d7b4 619dfd7 Author: increpare <analytic@gmail.com> Date: Thu Feb 24 09:02:29 2022 +0100 Merge pull request #845 from MisshapenSmiley/default-project-fix Fix trailing whitespace and inconsistent casing in default project commit 619dfd7 Author: increpare <analytic@gmail.com> Date: Thu Feb 24 09:01:13 2022 +0100 Update editor.html the casing isn't inconsistent as such - it's just formatting it as you might for a sentence commit d3f7b82 Author: MisshapenSmiley <minishapen@gmail.com> Date: Wed Feb 23 21:36:42 2022 -0500 ignore .DS_Store in all subdirectories commit 613ee32 Author: MisshapenSmiley <minishapen@gmail.com> Date: Wed Feb 23 19:05:41 2022 -0500 fix trailing whitespace and inconsistent formatting in default project commit a08d7b4 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Feb 23 19:59:52 2022 +0100 new unit test, censored another to make it SFW commit d76bc6d Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Feb 23 18:45:55 2022 +0100 build commit 8645061 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Feb 23 18:40:40 2022 +0100 tweak to standalone.html to make it compatible still with the source code extractor on the site https://www.puzzlescript.net/Documentation/extract_from_standalone_html.html commit 8cbffb0 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Feb 23 18:40:04 2022 +0100 tidy up compile.js formatting commit 654393d Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Feb 23 18:10:26 2022 +0100 work on #841 * moving from inliner->web-resource-inliner because of it modifying template strings * now the standalon_inlined.txt in /bin/ uses the compressed js, reducing file size from 400kb -> 200kb * removed the kinda pointless vestigial gamedat.js (used by standalone.html) commit af4a4d7 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Feb 23 17:47:14 2022 +0100 fixes #780 So the problem was that I was using the raw string declarations of font['X'], and the html inlining process was altering the multiline-strings by adding a space to the end of each line? I'll look into improving the standalone generation pipeline/migrating to a different library next. commit a7cd153 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Feb 23 16:33:09 2022 +0100 fixes #840 commit f28205e Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Feb 23 15:31:54 2022 +0100 fixes #775 commit 7d9dad4 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Feb 23 15:04:01 2022 +0100 fixes #834 20 felt better than 10 commit 9552c7c Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Feb 23 14:46:08 2022 +0100 fixes #838 commit 6ed95f3 Author: Stephen Lavelle <analytic@gmail.com> Date: Wed Feb 23 02:14:44 2022 +0100 fixes #832 - added lots of unit tests based on games lying around on github
I ran into a few problems with the compile process, so here's how I've fixed them.
DEVELOPMENT.mdup to date./bindoesn't exist yet, don't try to remove it./bin/Levelsdoesn't seem to be a thingDEVELOPMENT.md, "sandalone" -> "standalone"