Add breaking test indicating bug with distinct().order_by(some_field) #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Distinct() without field names will remove duplicate rows, but there are none in this case (because no joins).
|
@wadevries I'd like to accept this PR but it doesn't pass CI -- looks like your test fails on Django below 3.x. We are moving to support Django 2.2+ and higher now. |
|
@peterfarrell sorry for the reply-delay. The not-passing of the CI was expected. I created this PR to demonstrate a supposed bug by adding a breaking test. See my comment (and @maxpeterson 's response) in #204 . I'll close this PR as the issue appears to be a known, documented limitation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.