Rename email_verification_required to email_verified #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 2, 2015 10:15
* Add `email_verified` boolean to track if the user's email address has been verified.
|
@adam-incuna @kevinetienne @nologo Review |
Contributor
|
Looks good to me, happy to merge if no other comment |
kevinetienne
pushed a commit
that referenced
this pull request
Apr 2, 2015
Rename email_verification_required to email_verified
Contributor
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable
User.email_verification_requiredis named based upon the presumption that email verification is required when it is possible, and becomes a confusing variable name when applied outside of this context.Instead of modelling this presumption, we should instead be representing the raw information in the database. To that end, I propose that we rename the boolean to
email_verified, as that better represents the information that we need to store.This will require a migration of the values, as when
email_verified==True,email_verification_required==Falseand vice versa.