Adds ability to proxy requests insecurely #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johntron
force-pushed
the
proxy-secure-flag
branch
3 times, most recently
from
f266746
to
758ce85
Compare
|
I don't think the CI failures were caused by my changes. |
johntron
force-pushed
the
proxy-secure-flag
branch
from
758ce85
to
9210faa
Compare
|
Given the variety of options available in http-proxy, I'm going to close this in favor of the approach of passing through options to http-proxy itself in #459, which would solve this same issue |
This was referenced Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just exposes
http-proxy'ssecureoption via--proxy-secure. See README.md.Fixes #214