Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case where parsed config object doesn't have a prototype #365

Merged
merged 1 commit into from May 21, 2021
Merged

Handle case where parsed config object doesn't have a prototype #365

merged 1 commit into from May 21, 2021

Conversation

ilkkao
Copy link
Contributor

@ilkkao ilkkao commented May 5, 2021

Config objects read with ini library 2.0.0 don't have prototype, see: npm/ini@032fbaf

Handle that case

@ilkkao
Copy link
Contributor Author

@ilkkao ilkkao commented May 5, 2021

also fixes #314

@ilkkao
Copy link
Contributor Author

@ilkkao ilkkao commented May 13, 2021

The fix uses the minimal safe way of calling hasOwnProperty trick.

Copy link
Collaborator

@mhamann mhamann left a comment

lgtm, thanks for the fix!

@mhamann mhamann merged commit 2db6af4 into indexzero:master May 21, 2021
@ksathyanm
Copy link

@ksathyanm ksathyanm commented Jun 9, 2021

@mhamann When can we expect this fix to be released?

@ilkkao ilkkao changed the title Handle case where parsed config object hasn't prototype Handle case where parsed config object doesn't have a prototype Jun 9, 2021
@mhamann
Copy link
Collaborator

@mhamann mhamann commented Jun 21, 2021

Available now via https://www.npmjs.com/package/nconf/v/0.11.3

@ilkkao ilkkao deleted the ilkkao/fix-no-proto-case branch Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants