Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: add home page #75

Closed
wants to merge 1 commit into from
Closed

ui: add home page #75

wants to merge 1 commit into from

Conversation

Joe2k
Copy link
Contributor

@Joe2k Joe2k commented Aug 29, 2023

For #67

  • Moved current home page to dashboard which can be viewed only when logged in
  • Created new home page which will be like the landing page.
  • Added features(Whatever I know) and contributors.

Please feel free to suggest any edit and addition of stuff here as even I'm experimenting!

Adding screenshots here.
Screenshot 2023-08-30 at 2 18 29 AM
Screenshot 2023-08-30 at 2 18 49 AM

@Joe2k Joe2k requested review from punchagan and tcluri August 29, 2023 20:49
@Joe2k Joe2k self-assigned this Aug 29, 2023
@Joe2k
Copy link
Contributor Author

Joe2k commented Aug 30, 2023

@punchagan I'm not sure why the Integration tests are failing. I changed the base_url in test_ui from / to /login as now we don't navigate to login page from the home screen. But that also gives 404

Copy link
Member

@punchagan punchagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks @Joe2k. I had a few questions and suggestions, otherwise it looks great! 🎉

frontend/src/components/Dashboard.js Outdated Show resolved Hide resolved
frontend/src/components/Dashboard.js Outdated Show resolved Hide resolved
frontend/src/components/Dashboard.js Outdated Show resolved Hide resolved
frontend/src/components/Home.js Outdated Show resolved Hide resolved
@punchagan
Copy link
Member

@punchagan I'm not sure why the Integration tests are failing. I changed the base_url in test_ui from / to /login as now we don't navigate to login page from the home screen. But that also gives 404

I can fix the integration tests for you... once you address the review comments.

Previously, home page directly redirected to the login page. This commit adds a
home page that is visible to users even without being signed in. The previous
home page has now been moved to a dashboard page.

Closes #67
@punchagan
Copy link
Member

@punchagan I'm not sure why the Integration tests are failing. I changed the base_url in test_ui from / to /login as now we don't navigate to login page from the home screen. But that also gives 404

Navigating to the /login on the Django server doesn't work: the base_url was referring to the Django server. We could directly navigate to the /login on the webpack server, but then CSRF cookies are not set, and the API calls fail. So, I changed the tests to navigate to the base_url as before, but click on the Login button, before proceeding with the rest of the test.

@punchagan
Copy link
Member

This is great! Thanks for working on this, @Joe2k ! 🎉

Merged the changes manually as 40dd1fd

@punchagan punchagan closed this Aug 30, 2023
@punchagan punchagan deleted the home-page branch August 30, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants