Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement debounced search for players on Group Membership page #76

Merged
merged 2 commits into from Aug 30, 2023

Conversation

punchagan
Copy link
Member

Implemented the feature as discussed in #74 (comment)

Previously, we searched for players as we typed in the search bar, but this was
disabled in the commit where we changed the group memberships page to be
searchable by team names. This commit adds back this search functionality
where the search happens as the user types, but is debounced to make the search
occur only if the user stops typing for a second or so.
@punchagan punchagan requested a review from Joe2k August 30, 2023 04:12
@Joe2k
Copy link
Contributor

Joe2k commented Aug 30, 2023

Nice Perfect!

@punchagan punchagan merged commit 9834984 into main Aug 30, 2023
10 checks passed
@punchagan punchagan deleted the debounced-search branch August 30, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants