event: add location #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joe2k
force-pushed
the
tournament-location
branch
from
808a0f9
to
7ddc8a4
Compare
punchagan
requested changes
Aug 30, 2023
server/migrations/0026_merge_0025_event_location_0025_player_imported_data.py
Outdated
Show resolved
Hide resolved
Previously, we used get_or_create and iterated over a loop of the tournaments fetched from Ultimate Central. In this commit we switch over to using a bulk create, which would make the save more efficient, and also make sure that any updates from UC are updated in our database.
punchagan
force-pushed
the
tournament-location
branch
from
20dd4c3
to
02909dc
Compare
|
Merged after adding a preparatory commit to fix how we create/update events in the DB, and splitting your commits into atomic ones, @Joe2k ! Thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better visibility of tournaments. Also I'm gonna keep the events table as the base to build the tournament stuff on. So location will be very useful then