Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regarding decoherence_and_amp_decay #6

Closed
gitkarma opened this issue Dec 1, 2021 · 1 comment
Closed

Regarding decoherence_and_amp_decay #6

gitkarma opened this issue Dec 1, 2021 · 1 comment

Comments

@gitkarma
Copy link

gitkarma commented Dec 1, 2021

Information

  • Qiskit Terra version:
  • Python version:
  • Operating system:

What is the current behavior?

In dm_simulator.py
The amplitude decay ,thermalization and decoherence is applied at end of every clock cycle to all the qubits.
In the main code at line 1173 a for loop is applied for adding errors to all the qubits by calling _add_decoherence_and_amp_decay function .
Inside the function _add_decoherence_and_amp_decay again a for loop is applied for all the qubits at line 411.
I think one of the loop is redundant but not sure .
Request your comments on the same

Steps to reproduce the problem

What is the expected behavior?

Suggested solutions

@biplab37
Copy link
Member

biplab37 commented Dec 9, 2021

@gitkarma Thanks for pointing it out. It seems like there have been a mistake. I will look into it carefully, maybe discuss with the other developers and fix this issue soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants