Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aide::cron: Add max_mail_lines feature. #15

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

olifre
Copy link
Contributor

@olifre olifre commented Aug 4, 2022

This allows to limit the maximum number of lines sent in change mails before the mail is truncated. By default, no truncation happens.

This functionality is useful to prevent too large mails when OS updates happen, which may be bounced by mail servers otherwise.

@kekogya kekogya added the enhancement New feature or request label Aug 4, 2022
@kekogya
Copy link
Contributor

kekogya commented Aug 5, 2022

@olifre First off, thank you for your contribution. There appears to be some conflicts due to a pull request and changes that are in master. Could you please please re-base your pull request with the updated master? Also, for the head command, isn't it supposed to have a space after the -n? The code I am referencing are below:

${head_path} -n${max_mail_lines}
${_head_filter}${mail_path}

This allows to limit the maximum number of lines sent in change mails
before the mail is truncated. By default, no truncation happens.
This functionality is useful to prevent too large mails when OS updates
happen, which may be bounced by mail servers otherwise.
@olifre
Copy link
Contributor Author

olifre commented Aug 5, 2022

There appears to be some conflicts due to a pull request and changes that are in master. Could you please please re-base your pull request with the updated master?

Sure, I saw the recent additions only now — PR updated 😄 .

Also, for the head command, isn't it supposed to have a space after the -n?

In fact, both are accepted by head, but you are correct that adding the space is likely more standard conforming in case there is another head implementation out there. I've added the space and force-pushed 😉.

@kekogya kekogya merged commit 9f58fd3 into indiana-university:master Aug 9, 2022
@kekogya
Copy link
Contributor

kekogya commented Aug 9, 2022

@olifre thank you for getting the branch PR updated. I will work on publishing an updated module to the forge in the next couple of days.

@olifre olifre deleted the add_max_mail_lines branch August 10, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants