Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass correct variable to class #3

Merged
merged 1 commit into from
Jan 24, 2020
Merged

pass correct variable to class #3

merged 1 commit into from
Jan 24, 2020

Conversation

twem
Copy link

@twem twem commented Jan 22, 2020

inccorect value is being used to determine whcih crontab entry to create

@twem twem requested a review from kekogya January 23, 2020 10:39
@kekogya
Copy link
Contributor

kekogya commented Jan 23, 2020

@twem I will take a look.

@kekogya kekogya added the bug Something isn't working label Jan 23, 2020
kekogya
kekogya approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@kekogya kekogya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twem Thanks for catching that and submitting a pull request. I will publish the update to the forge soon.

@kekogya kekogya merged commit 08367ce into indiana-university:master Jan 24, 2020
@twem
Copy link
Author

twem commented Jan 24, 2020

Thanks, can you also please take a look at

#4
Let me know if you want me to create a PR for the change

@kekogya
Copy link
Contributor

kekogya commented Jan 24, 2020

Thanks, can you also please take a look at

#4
Let me know if you want me to create a PR for the change

I have commented on that. Let me know what your thoughts are on those comments.

@kekogya
Copy link
Contributor

kekogya commented Jan 24, 2020

The latest module has been posted to the forge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kekogya kekogya kekogya approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twem @kekogya