Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Warnings in v6.12.0 #6

Merged
merged 3 commits into from
Feb 11, 2020

Conversation

cheyngoodman
Copy link

@cheyngoodman cheyngoodman commented Feb 5, 2020

validate_legacy has been deprecated:

Warning: This method is deprecated, please use the stdlib validate_legacy function,
    with Stdlib::Compat::Absolute_Path. There is further documentation for validate_legacy function in the README. at ["/etc/puppetlabs/code/environments/vagrant/modules/aide/manifests/watch.pp", 20]:
    (location: /etc/puppetlabs/code/environments/vagrant/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')

Use Hiera instead of params.pp and setup data/common.yaml.

Warning: .../modules/aide/data/common.yaml: file does not contain a valid yaml hash

Tested this change against CentOS 7/8 Ubuntu1804/1910.

Checked code with pdk validate and pdk test unit, test unit completes with 216 examples, 0 failures.

Cheyn Goodman added 3 commits February 5, 2020 13:04
Attempt to resolve this issue:
  Warning: .../modules/aide/data/common.yaml: file does not contain a valid yaml hash
Warning: This method is deprecated, please use the stdlib validate_legacy function,
with Stdlib::Compat::Absolute_Path. There is further documentation for validate_legacy function in the README. at ["/etc/puppetlabs/code/environments/vagrant/modules/aide/manifests/watch.pp", 20]:
(location: /etc/puppetlabs/code/environments/vagrant/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
@kekogya kekogya added the enhancement New feature or request label Feb 11, 2020
@kekogya kekogya merged commit f3d9997 into indiana-university:master Feb 11, 2020
@kekogya
Copy link
Contributor

kekogya commented Feb 11, 2020

Thank you for the pull request. I will be updating the forge module soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants