Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aide::config: Add report_ignore_e2fsattrs config parameter. #7

Merged
merged 3 commits into from
Feb 27, 2020

Conversation

olifre
Copy link
Contributor

@olifre olifre commented Feb 23, 2020

This allows to ignore selected ext2 file attributes in the
final report. Unset by default.
Very useful to ignore e.g. I (indexed directory)
which on some systems gets flipped automatically
if the number of files in a directory is increased
(example: Log file directories due to rotation).

For more details, see for example this upstream discussion:
aide/aide#47
which considers to ignore e2fsattrs which can not be set or removed.

This allows to ignore selected ext2 file attributes in the
final report. Unset by default.
Very useful to ignore e.g. I (indexed directory)
which on some systems gets flipped automatically
if the number of files in a directory is increased
(example: Log file directories due to rotation).
@olifre
Copy link
Contributor Author

olifre commented Feb 23, 2020

I'm unsure why the tests fail — is undef not allowed as a default value?

@kekogya kekogya added the enhancement New feature or request label Feb 24, 2020
@kekogya
Copy link
Contributor

kekogya commented Feb 24, 2020

I'm unsure why the tests fail — is undef not allowed as a default value?

Did you add the unit test for the changes you added? what does pdk test unit show when you run that?

@olifre
Copy link
Contributor Author

olifre commented Feb 24, 2020

@kekogya Thanks, just learning PDK. I see the issue is caused by the defaults in data/common.yml only applying to aide::init, but the tests instantiate aide::config directly, and the current solution used for other values seems to be to just set all parameters in config_spec.rb.

I'll extend accordingly and add a test for the new feature.

@olifre
Copy link
Contributor Author

olifre commented Feb 24, 2020

Things should become green now 😄.

@kekogya
Copy link
Contributor

kekogya commented Feb 26, 2020

Thank you for adding the unit test. I will review the pull request and merge soon.

@kekogya kekogya merged commit a98f3c7 into indiana-university:master Feb 27, 2020
@kekogya
Copy link
Contributor

kekogya commented Feb 27, 2020

@olifre pull has been merged. I will be updating the forge module shortly.

@olifre
Copy link
Contributor Author

olifre commented Feb 27, 2020

Thanks! 👍

@olifre olifre deleted the e2fsattrs branch February 28, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants