Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose user blocking in the admin UI #3243

Closed
ThiefMaster opened this issue Feb 16, 2018 · 1 comment · Fixed by #4363
Closed

Expose user blocking in the admin UI #3243

ThiefMaster opened this issue Feb 16, 2018 · 1 comment · Fixed by #4363

Comments

@ThiefMaster
Copy link
Member

ThiefMaster commented Feb 16, 2018

There's User.is_blocked which is properly implemented in the backend but currently only settable via indico shell.

Ideally, the UI should:

  • Let admins block/unblock users
  • Show that a user account is blocked when viewing their profile and maybe also in the user search results
  • Filter out blocked users when searching in non-admin areas (?)

Since we don't have any amazing place to put admin-level stuff for specific users I would either:

  • Put it on the "Accounts" tab of the user settings. That's the least weird place right now.
  • Add a new "Admin" tab, but with just block/unblock it might look a bit naked

The actual blocking/unblocking would be done in a new RH (similar to what RHAPIBlockKey does for blocking/unblocking API keys), but the action should be logged as well (not sure why we don't do that for API keys)

For the information in the profile I would show a message like we currently do for the system user (base.html in the users module). The search results can simply use an icon.

@ThiefMaster
Copy link
Member Author

ThiefMaster commented Oct 3, 2018

Did you find this issue through Hacktoberfest?
If you would like to work on it, please leave a comment here and join our IRC channel (#indico on freenode) for any questions you might have.

Instructions on how to setup a local development environment for Indico can be found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants