Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Error with stacktrace instead of friendly error mesage in case of duplicate logins #3250
In case of a duplicate account email I would expect an friendly error message pointin g to the reset-password page instead of an error " There was a database error while processing..." with stack-trace
We'll fix that in 2.1, here's a patch for it if you want to hotfix it:
diff --git a/indico/modules/auth/forms.py b/indico/modules/auth/forms.py index a9ee7200b1..faeed8d95b 100644 --- a/indico/modules/auth/forms.py +++ b/indico/modules/auth/forms.py @@ -102,7 +102,7 @@ class MultipassRegistrationForm(SyncedInputsMixin, IndicoForm): class LocalRegistrationForm(RegistrationForm): - email = EmailField(_('Email address')) + email = EmailField(_('Email address'), [_check_existing_email]) username = StringField(_('Username'), [DataRequired(), _check_existing_username], filters=[_tolower]) password = PasswordField(_('Password'), [DataRequired(), Length(min=5)]) confirm_password = PasswordField(_('Confirm password'), [DataRequired(), ConfirmPassword('password')])