Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take minutes in markdown #3386

Closed
dguest opened this issue Jun 1, 2018 · 13 comments · Fixed by #5500
Closed

Take minutes in markdown #3386

dguest opened this issue Jun 1, 2018 · 13 comments · Fixed by #5500

Comments

@dguest
Copy link

dguest commented Jun 1, 2018

Markdown seems to be supported in a lot of places in indico, but I can't figure out how to enter minutes in markdown format. I seem to only have the option to use the built-in HTML based editor. Could we add an option to add the minutes as markdown?

I can get around this using browser extensions (i.e. MarkdownHere) but given the wide support that indico has for markdown it seems like it might be a trivial extension.


Main tasks here:

  • Find a suitable markdown editor; this can be either the one currently integrated in Indico (least preferred option!) or a better one; it does not need live preview of the formatting (and should NOT be a WYSIWYG editor), but toggling a preview (e.g. like it's done on GitHub) would be a useful feature.
  • Include the new editor in the minute editing dialog; if possible and useful, move that dialog to React
  • Provide a way to switch between editing modes - this can be either a user setting (less flexible) or within the editing dialog (more complex, needs type conversion). To be discussed with the Indico team.
  • When editing existing minutes, the editor corresponding to the existing format shall be used. Possibly provide a way to switch (convert to the other type server-side in that case, warn user that some formatting may be lost in case of HTML->Markdown).
  • Make sure the "Compile Minutes" still works - if any of the minutes included are HTML, then the markdown ones need to be converted to HTML for the compiled list, otherwise Markdown can and should be kept.
@ThiefMaster
Copy link
Member

It's supported in the backend, but we do not have frontend for it at the moment

@dguest
Copy link
Author

dguest commented Jun 1, 2018

Thanks for the fast response! As I said, right now I'm writing the notes with Markdown Here --- just entering the text into the standard window and then running the conversion.

It's a bit clumsy though, because editing as "source" prevents Markdown Here from running (because the window is a plane text window) and editing with the rich editor means that return inserts a paragraph break (there may be other oddities too). There are workarounds of course (shift+return seems to do what I want), but it would be nice if there was a way to turn off the auto formatting in the text window too.

@ThiefMaster
Copy link
Member

If you use a separate markdown editor, convert the notes to HTML, and paste them in the source view of the rich editor widget in Indico.

If you put markdown as text in the editor, it will not be converted to HTML even when we do start supporting markdown for minutes (we store in the database whether it's HTML/Markdown, and currently it's always HTML).

@pferreir
Copy link
Member

pferreir commented Jun 1, 2018

It would be great to have a Markdown-based editor for the minutes. It would have to be something simple enough and comparable to CKEditor in terms of functionality, however.

@ThiefMaster
Copy link
Member

I'd let the user switch between markdown and HTML (with a profile setting for the default) - for less technical users the WYSIWYG editor is probably nicer, but myself I'd rather write markdown (if only to be able to use backticks to mark monospace/code instead of having to go through the huge style list of ckeditor to select code...)

@dguest
Copy link
Author

dguest commented Jun 1, 2018

Hi @ThiefMaster, this sounds very nice.

I frequently take notes with a text editor during meetings (especially if the internet connection is lousy), so having the bullet points and citations that markdown provides would be quite a plus.

@adavidzh
Copy link

It would have to be something simple enough and comparable to CKEditor in terms of functionality, however.

Regarding CKEditor (assuming that that is what indico is using) there is a markdown plugin. I don't know what prevents its use.

@ThiefMaster
Copy link
Member

Updated: 09 Aug 2015

That doesn't sound very promising. :/
Quite a few open issues as well.

And I wonder if this actually keeps markdown or produces HTML in the end (which would not be desirable, we want to store markdown when someone writes markdown).

At least I usually don't want any WYSIWYG when writing markdown but write plain markdown and not have to switch back to WYSIWYG mode before saving (which is needed e.g. when using the HTML source view in regular CKEditor).

@bpedersen2
Copy link
Contributor

https://github.com/Ionaru/easy-markdown-editor looks promising as a frontend

@ThiefMaster
Copy link
Member

ThiefMaster commented Aug 13, 2021

The first thing I noticed in their demo is the lack of proper monospace/code block support. Neither 4-space indentation nor triple-backtick fences are correctly highlighted in the editor view... :/

And issue related to that is open for 2 years now... Ionaru/easy-markdown-editor#96

@bpedersen2
Copy link
Contributor

Seems to be not much different for the github editor here ( using the preview toggle it is correctly styled in the demo.)

@ThiefMaster
Copy link
Member

Yeah. But the GitHub editor uses pure plaintext in the editing view - IMHO not having a feature at all is better than having a poorly implemented feature ;)

@pferreir
Copy link
Member

This one doesn't look bad either: https://github.com/HarryChen0506/react-markdown-editor-lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants