New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms don't validate email #3471

Closed
Marx1st opened this Issue Jul 24, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@Marx1st

Marx1st commented Jul 24, 2018

Hi!

I'm not sure if this is intentional or not, but the email field in the registration form does not apply any checks whether the input is a valid email address or not.
This leads to eg. the input of incorrect email addresses while registering for an event, which have to be corrected by hand.
We use Indico 2.1.2

Regards
Tobias

@ThiefMaster

This comment has been minimized.

Member

ThiefMaster commented Aug 8, 2018

We do validate it, the validation logic there is just really poor... 🙈

/^.+@([^.@][^@]+)$/

The server-side validation is a bit better but still fails to catch typos like foo@example..com :/

@ThiefMaster

This comment has been minimized.

Member

ThiefMaster commented Aug 8, 2018

We'll include improved validation in 2.1.3 (will be released this week).

ThiefMaster added a commit that referenced this issue Aug 8, 2018

Properly validate email addresses
This includes checking if the domain part is actually a valid domain
(dns lookup).

fices #3471

@ThiefMaster ThiefMaster self-assigned this Aug 8, 2018

@ThiefMaster ThiefMaster added this to the v2.1 milestone Aug 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment