New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add external user to event ACL #3562

Closed
ThiefMaster opened this Issue Oct 1, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@ThiefMaster
Copy link
Member

ThiefMaster commented Oct 1, 2018

We did not support this in the past, but with the new ACL widget we allow selecting external users, but saving the entry fails:

Id 'cern-ldap:loremipsumloremipsum' is not a number and allow_pending=False

Let's either

  • disable searching externals or
  • allow saving such users

I'm inclined to go for the second option, since it's clearly useful in some cases, e.g. this:

but i want to import contacts because i nead to restrict the access to a a conference to a group of users, so i need to have these users defined...

@pferreir

This comment has been minimized.

Copy link
Member

pferreir commented Nov 21, 2018

If there is no inconvenience to saving those users, I can't see why not. The only issue I can see is pending identities remaining stale whenever an identity manager is removed from the config. But that doesn't seem like a big deal to me (and it's a problem that already exists with speakers, etc...).

@pferreir pferreir added the p-medium label Nov 21, 2018

@culpinnis

This comment has been minimized.

Copy link

culpinnis commented Jan 10, 2019

Is there any news on this topic?
I have this issue very often because our indico instance is quite new. This means that I have the majority of speakers (and users) already in our LDAP, but they did not register to the indico (yet). Sometimes they won't even register because, for example, a secretary is managing a lecture. But nonetheless, it would be nice to set the speaker directly based on the LDAP entry.
Best wishes
Chris

@ThiefMaster

This comment has been minimized.

Copy link
Member Author

ThiefMaster commented Jan 10, 2019

Adding such a user as a speaker is already possible - when searching for a user to add them as a speaker or chairperson you can select "Users with no Indico account" to search in LDAP as well.

This particular issue only happens on the "protection" page when adding someone to the ACL there. But if your event isn't access-restricted that case won't apply to you.

@culpinnis

This comment has been minimized.

Copy link

culpinnis commented Jan 10, 2019

Thanks for your very fast reply :) !
For me, it is not working yet.
image

Could it be, because the access to the created lecture is (still) restricted to organisational persons? - it is located in a testing category until it will be available publicly.
Best wishes
Chris

ps. For me, it was possible to set someone without an indico account on the protection page - for example as a manager of a conference - but I can't save this person as a chairperson. That wasn't a big deal to me, because a conference manager will register to the indico system anyway.

@ThiefMaster

This comment has been minimized.

Copy link
Member Author

ThiefMaster commented Jan 10, 2019

OK indeed, the bug is there as well. I'm very surprised nobody else noticed this...

ThiefMaster added a commit that referenced this issue Jan 10, 2019

Fix selecting external users in person links
This broke during a refactoring in 683efb9
see #3562

@ThiefMaster ThiefMaster self-assigned this Jan 10, 2019

@ThiefMaster

This comment has been minimized.

Copy link
Member Author

ThiefMaster commented Jan 10, 2019

Found the problem, it was broken during a refactoring in 683efb9. I don't think we'll make a new 2.1.x release just for this but you could easily apply the fix manually.

If you want to patch the file(s) manually, you can edit /opt/indico/.venv/lib/python2.7/site-packages/indico/... and reload/restart uwsgi once you are done.

@culpinnis

This comment has been minimized.

Copy link

culpinnis commented Jan 10, 2019

Okay great! I will apply the fix manually.

Best wishes & many thanks
Chris

pferreir added a commit to pferreir/indico that referenced this issue Jan 14, 2019

Fix selecting external users in person links
This broke during a refactoring in 683efb9
see indico#3562

pferreir added a commit to pferreir/indico that referenced this issue Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment