Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate email addresses in contribution csv import #3568

Closed
ThiefMaster opened this issue Oct 8, 2018 · 4 comments

Comments

@ThiefMaster
Copy link
Member

commented Oct 8, 2018

Currently we don't, and if someone mixes up e.g. affiliation and email that results in very messy data.

import_contributions_from_csv already has some checks, but it's missing one using validate_email. Note: The email is optional, so we should only validate it if it's not empty.

@zilehuda

This comment has been minimized.

Copy link

commented Oct 8, 2018

working on it (Y)

@zilehuda

This comment has been minimized.

Copy link

commented Oct 8, 2018

Can you please explain more about your issue ? on which file / module you are using import_contributions_from_csv

@ThiefMaster

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2018

Nice! If you have any questions feel free to join our IRC channel (#indico on freenode) or ask here.

Also, to test it, you might want to install Indico locally - instructions on how to setup a local development environment can be found here.

Regarding your second comment: A quick search shows that the function is defined in indico/modules/events/contributions/util.py.
To actually use it from the UI, you need to create an event (type "conference"), then go to the "Contributions" page in the management area, and click on "Import".

@ThiefMaster

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2018

@zilehuda: In case you are still working on this: Someone else provided a PR for it yesterday, so this issue is now solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.