Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation on latitude/longitude fields when editing rooms #4103

Closed
ThiefMaster opened this issue Oct 8, 2019 · 1 comment

Comments

@ThiefMaster
Copy link
Member

commented Oct 8, 2019

Currently they don't specify any step, so the default step is 1. This of course doesn't work well for coordinates (Firefox: validation error after editing; Edge: validation error when just submitting the form w/o changing the coordinates), so we can either:

  • specify step="0.000000001" (with a reasonable amount of zeroes) or
  • use a normal type="text" field

I think using a text field is the better option here, since having the up/down arrows for number input fields isn't useful in this case either.

@ThiefMaster ThiefMaster added this to the v2.2 milestone Oct 8, 2019
@pferreir pferreir self-assigned this Oct 8, 2019
@ThiefMaster

This comment has been minimized.

Copy link
Member Author

commented Oct 15, 2019

Not sure why github didn't auto-close this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.