Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main Category doesn't use category description, inconsistent behavior #4231

Closed
brittyazel opened this issue Jan 9, 2020 · 3 comments · Fixed by #4244
Closed

Main Category doesn't use category description, inconsistent behavior #4231

brittyazel opened this issue Jan 9, 2020 · 3 comments · Fixed by #4244

Comments

@brittyazel
Copy link
Contributor

brittyazel commented Jan 9, 2020

The main (root) category seems to always have the description:
"Welcome to Indico. The Indico tool allows you to manage complex conferences, workshops and meetings.
To start browsing, please select a category below."

This is confusing, as you can add a custom title and description to the root category, however those seem to just be ignored. Weirdly though, setting a Logo on the main category does put the logo in the correct location.

It would be fantastic if the parent category would use the custom description that I have set instead of the default (above), though if this is impossible it would make it more clear if the option to edit the description of the main category were disabled.

@ThiefMaster
Copy link
Member

ThiefMaster commented Jan 14, 2020

The custom title shows up in the breadcrumbs; the only place I could imagined to show it on the home page would be in place of "Main categories", but this could look a bit strange in the breadcrumbs etc then where people are used to "Home". The title shown there is also dynamic depending on whether we have subcategories or not:

{% if category.is_root and category.children %}
    {% trans %}Main categories{% endtrans %}
{% elif category.is_root %}
    {% trans %}All events{% endtrans %}
{% else %}
    {{ category.title }}
{% endif %}

OTOH, just using the title would allow people to be more flexible there, and I guess everyone could find something that fits nicely both there and in the breadcrumbs.


For the description I think it could indeed be nice to allow customization. The disadvantage is that you lose i18n by making it customizable unless we keep the "hardcoded" (and translated) default but show the custom description only if there is one.


Another option would of course be to just hide the description field for the root category so it cannot be edited at all.

@pferreir
Copy link
Member

pferreir commented Jan 14, 2020

I agree with @ThiefMaster. I'd prefer to show the default description if there's none set, so that i18n works in that case.

@ThiefMaster
Copy link
Member

ThiefMaster commented Jan 14, 2020

hm for the title we'd also lose i18n unless we hardcode "Home" (or whatever the default is) to keep using the dynamic titles and only override it if you change it to something else...

@ParthS007 ParthS007 self-assigned this Jan 15, 2020
@ParthS007 ParthS007 added this to To do in Release 2.3 via automation Jan 16, 2020
@ParthS007 ParthS007 moved this from To do to Review in progress in Release 2.3 Jan 16, 2020
@ParthS007 ParthS007 moved this from Review in progress to Reviewer approved in Release 2.3 Jan 22, 2020
Release 2.3 automation moved this from Reviewer approved to Done Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Release 2.3
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants