Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LOCAL_GROUPS setting to disable local groups everywhere #4260

Closed
7 tasks done
ThiefMaster opened this issue Jan 27, 2020 · 0 comments · Fixed by #4265
Closed
7 tasks done

Add LOCAL_GROUPS setting to disable local groups everywhere #4260

ThiefMaster opened this issue Jan 27, 2020 · 0 comments · Fixed by #4265
Assignees
Projects
Milestone

Comments

@ThiefMaster
Copy link
Member

ThiefMaster commented Jan 27, 2020

This is a prerequisite for #3040 (see the comments there).

  • Add a new LOCAL_GROUPS (default: True) setting for indico.conf
  • Add it to the docs for the indico.conf settings
  • If local groups are disabled with this setting, then:
    • Hide local group features in the admin area
    • Do not return local groups when searching for groups
    • Always return false when checking membership against local group (in case local groups were created and added to ACLs before turning off the setting)
    • Make sure saving such an ACL fails gracefully. We do something similar for remote (multipass) groups which do not exist anymore. Keep in mind that we have different fields for ACLs; the React one used e.g. in the Room Booking settings, and the classic one used e.g. when editing the protection of an event. I think principal_from_fossil and principal_from_identifier are the places to look at for this.
@ThiefMaster ThiefMaster added this to the v2.3 milestone Jan 27, 2020
@ParthS007 ParthS007 added this to To do in Release 2.3 via automation Jan 28, 2020
@ParthS007 ParthS007 moved this from To do to In progress in Release 2.3 Jan 28, 2020
Release 2.3 automation moved this from In progress to Done Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Release 2.3
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants