Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace <input type="time"> fields with text-based fields #4399

Closed
pferreir opened this issue Apr 8, 2020 · 2 comments · Fixed by #4440
Closed

Replace <input type="time"> fields with text-based fields #4399

pferreir opened this issue Apr 8, 2020 · 2 comments · Fixed by #4440
Assignees
Projects
Milestone

Comments

@pferreir
Copy link
Member

pferreir commented Apr 8, 2020

The way browsers handle time fields is not consistent across vendors and creates lots of problems especially to people on Edge, who have to deal with an awful built-in time picker widget.
Additionally, these widgets rely on the system locale, which may differ from the Indico locale.

We should replace these with a widget which is easy to use and based on whatever locale is selected in Indico.

@pferreir pferreir added this to the v2.3 milestone Apr 8, 2020
@pferreir pferreir added this to To do in Release 2.3 via automation Apr 8, 2020
@ThiefMaster ThiefMaster changed the title Replace input="time" fields with text-based fields Replace <input type="time"> fields with text-based fields Apr 8, 2020
@ThiefMaster
Copy link
Member

The problem with making it anything but a plain hh:mm in 24h format is that we then need some extra javascript to convert and store the real value in a hidden field. :/

Would be interesting to see if there are any decent time pickers out there; I don't think the one we did for room booking is sufficient for the other cases where we use time fields right now.

@ThiefMaster
Copy link
Member

We also have one such field in the registration form (legacy angular code), so using anything halfway decent there may be hard... not sure if you can e.g. safely render a react component in there.

@Leats Leats self-assigned this Apr 9, 2020
@Leats Leats moved this from To do to In progress in Release 2.3 Apr 9, 2020
@Leats Leats moved this from In progress to Review in progress in Release 2.3 Apr 24, 2020
Release 2.3 automation moved this from Review in progress to Done May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Release 2.3
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants