Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mixing events + subcategories in a category #4679

ThiefMaster opened this issue Oct 28, 2020 · 0 comments · Fixed by #4725

Allow mixing events + subcategories in a category #4679

ThiefMaster opened this issue Oct 28, 2020 · 0 comments · Fixed by #4725


Copy link

This is fully supported in the backend and the frontend does not look awful. We just prohibit it when creating new events/categories.

Removing those restrictions and ensuring (especially in the category picker) that a case of a category containing both is properly handled (we may even be able to remove some code there related to restricting things based on what a category contains!) should be enough.

Once we did this, we can finally cache certain things such as category event counts, instead of querying freshly from the DB every single time (ideally in a separate task).

@ThiefMaster ThiefMaster created this issue from a note in Release 3.0 (To do) Oct 28, 2020
@ThiefMaster ThiefMaster added this to the v3 milestone Nov 3, 2020
@plourenco plourenco self-assigned this Nov 25, 2020
@ThiefMaster ThiefMaster moved this from To do to In progress in Release 3.0 Nov 26, 2020
Release 3.0 automation moved this from In progress to Done Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
No open projects
Release 3.0

Successfully merging a pull request may close this issue.

2 participants